Bug 289096
| Summary: | REGRESSION(289248@main?): Null LocalFrame dereference during render tree teardown | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Charlie Wolfe <charliew> |
| Component: | New Bugs | Assignee: | Charlie Wolfe <charliew> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Charlie Wolfe
Crash data indicates that dereferencing a null LocalFrame during render tree teardown has recently become more likely. All crashes occur beneath the disconnectDescendantFrames call in Document::willBeRemovedFromFrame, which constructs a NavigationDisabler that previously held a RefPtr to LocalFrame but, after 289248@main, now holds a WeakPtr. Revert it to a RefPtr to speculatively fix this crash.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Charlie Wolfe
<rdar://problem/145408212>
Charlie Wolfe
Pull request: https://github.com/WebKit/WebKit/pull/41858
EWS
Committed 291590@main (e4ba0ad28c51): <https://commits.webkit.org/291590@main>
Reviewed commits have been landed. Closing PR #41858 and removing active labels.
EWS
Committed 289651.230@safari-7621-branch (b957e34486ff): <https://commits.webkit.org/289651.230@safari-7621-branch>
Reviewed commits have been landed. Closing PR #2741 and removing active labels.