Bug 28875

Summary:

Post a notification when a WebView is closing

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sfalken

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Windows XP

Attachments:

Description	Flags
Patch v1	sullivan: review+

Adam Roben (:aroben)

Reported 2009-09-01 08:35:26 PDT

Created attachment 38866 [details] Patch v1 This is useful for situations where some code wants to react to the WebView closing but isn't in charge of the WebView and can't otherwise be notified. This notification could replace IWebUIDelegatePrivate::webViewClosing if we decide that the notification system isn't too burdensome. Reviewed by NOBODY (OOPS!). Need a short description and bug URL (OOPS!) * Interfaces/IWebViewPrivate.idl: Added the WebViewWillCloseNotification string constant. * WebKit.vcproj/WebKit.vcproj: Link against comsuppw.lib in all configurations so that we can use _bstr_t. * WebView.cpp: (WebView::close): Post the WebViewWillCloseNotification. --- 4 files changed, 32 insertions(+), 5 deletions(-)

Attachments
Patch v1 (10.75 KB, patch) 2009-09-01 08:35 PDT, Adam Roben (:aroben)	sullivan: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2009-09-01 09:35:33 PDT

Fixed in r47940

Note You need to log in before you can comment on or make changes to this bug.