Bug 288644
| Summary: | CaretPosition should be EnabledBySetting | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | CSS | Assignee: | Tim Nguyen (:ntim) <ntim> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | darin, koivisto, rbuis, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=172137 | ||
Sam Sneddon [:gsnedders]
https://commits.webkit.org/287047@main (bug 172137) added Document.caretPositionFromPoint().
However, while Document.caretPositionFromPoint() itself has [EnabledBySetting=CaretPositionFromPointEnabled] neither CaretPosition nor CaretPositionFromPointOptions do. These should also be behind the flag, because otherwise we break anyone doing anything like `if (window.CaretPosition)` — or the mdn-bcd-collector trying to fetch meaningful data about what browser supports the related APIs.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/145688017>
Tim Nguyen (:ntim)
Pull request: https://github.com/WebKit/WebKit/pull/41567
EWS
Committed 291314@main (c4e24f803946): <https://commits.webkit.org/291314@main>
Reviewed commits have been landed. Closing PR #41567 and removing active labels.
EWS
Committed 289651.204@safari-7621-branch (3f50535815b5): <https://commits.webkit.org/289651.204@safari-7621-branch>
Reviewed commits have been landed. Closing PR #2700 and removing active labels.