Bug 28849

Summary:

Make safariPath() work for Debug builds of Safari on Windows

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Windows XP

Attachments:

Description	Flags
Patch v1	sam: review+
Fall back to a Release version of Safari if a Debug one doesn't exist	sam: review+

Adam Roben (:aroben)

Reported 2009-08-31 10:42:31 PDT

Created attachment 38821 [details] Patch v1 Reviewed by NOBODY (OOPS!). * Scripts/webkitdirs.pm: (safariPath): If the user is working with a Debug build, add the _debug suffix to Safari.exe. --- 2 files changed, 18 insertions(+), 3 deletions(-)

Attachments
Patch v1 (1.57 KB, patch) 2009-08-31 10:42 PDT, Adam Roben (:aroben)	sam: review+	Details Formatted Diff Diff
Fall back to a Release version of Safari if a Debug one doesn't exist (1.69 KB, patch) 2009-08-31 11:06 PDT, Adam Roben (:aroben)	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2009-08-31 11:06:56 PDT

Created attachment 38822 [details] Fall back to a Release version of Safari if a Debug one doesn't exist <http://webkit.org/b/28849> Reviewed by NOBODY (OOPS!). * Scripts/webkitdirs.pm: (safariPath): If the user is working with a Debug build, but there's no Debug version of Safari present, fall back to using a Release version of Safari. --- 2 files changed, 19 insertions(+), 3 deletions(-)

Adam Roben (:aroben)

Comment 2 2009-08-31 11:12:47 PDT

Committed in r47898 and r47899.

Note You need to log in before you can comment on or make changes to this bug.