Bug 28846

Summary:

Support conditional breakpoints in the backend

Product:

WebKit

Reporter:

Alexander Pavlov (apavlov) <apavlov>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

pfeldman, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

21449

Attachments:

Description	Flags
patch (nits from https://bugs.webkit.org/show_bug.cgi?id=21449#c9 fixed)	none
backend patch with JavaScript stubs in place	timothy: review+

Alexander Pavlov (apavlov)

Reported 2009-08-31 06:11:16 PDT

Created attachment 38810 [details] patch (nits from https://bugs.webkit.org/show_bug.cgi?id=21449#c9 fixed) This bug is to track the conditional breakpoints implementation in the Web Inspector backend. The parent bug for conditional breakpoints is https://bugs.webkit.org/show_bug.cgi?id=21449

Attachments
patch (nits from https://bugs.webkit.org/show_bug.cgi?id=21449#c9 fixed) (11.85 KB, patch) 2009-08-31 06:11 PDT, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
backend patch with JavaScript stubs in place (15.36 KB, patch) 2009-08-31 11:32 PDT, Alexander Pavlov (apavlov)	timothy: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2009-08-31 10:41:05 PDT

Alexander, could you please double check that appropriate stubs in the front-end are installed. We don't want this back-end change to break inspector functionality in between of your commits.

Alexander Pavlov (apavlov)

Comment 2 2009-08-31 11:32:19 PDT

Created attachment 38824 [details] backend patch with JavaScript stubs in place same patch as 38810 but with frontend JavaScript stubs to follow the new InspectorBackend API so as to avoid the breakpoint functionality breakage

Pavel Feldman

Comment 3 2009-09-01 02:32:10 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorBackend.cpp M WebCore/inspector/InspectorBackend.h M WebCore/inspector/InspectorBackend.idl M WebCore/inspector/JavaScriptDebugServer.cpp M WebCore/inspector/JavaScriptDebugServer.h M WebCore/inspector/front-end/Breakpoint.js M WebCore/inspector/front-end/BreakpointsSidebarPane.js M WebCore/inspector/front-end/ScriptsPanel.js Committed r47919

Note You need to log in before you can comment on or make changes to this bug.