Bug 288418
| Summary: | Make NameScope a read-only class | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kiet Ho <kiet.ho> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | kiet.ho, koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Kiet Ho
NameScope is currently a struct, so it's easy to construct invalid NameScopes that breaks invariants. For example: None type with non-empty name vector, or Ident type with empty name vector. Therefore NameScope should be "hermantic" - once it's created, it's not possible to change it. The constructor should also be changed such that it's not possible to construct an invalid NameScope.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/145515115>
Kiet Ho
Some comments about the purpose of the class would be nice to, since this is *very* different from ScopedName.
Radar WebKit Bug Importer
<rdar://problem/145515199>