Bug 288151 – git-webkit is not posting PR links to bugzilla bugs

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Elliott Williams]

I've started having trouble getting git-webkit to post PR links to the bugs it opens. I'm not entirely sure what's wrong, and I don't see any interesting logging from the tool.

Example from today:

> git webkit land --no-add --no-rebase
Total errors found: 0 in 1 files
Pushing to fork, which is classified as a public remote
Verifying commits in 'default' mode
Attempting to push 1 batch of commits to fork...
Verified 1 novel commit to fork are safe to push
Enumerating objects: 13, done.
Counting objects: 100% (13/13), done.
Delta compression using up to 10 threads
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 877 bytes | 109.00 KiB/s, done.
Total 7 (delta 6), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (6/6), completed with 6 local objects.
remote: 
remote: Create a pull request for 'eng/Work-around-internal-build-failure-by-adding-explicit-_WebKit_SwiftUI-import' on GitHub by visiting:
remote:      https://github.com/emw-apple/WebKit/pull/new/eng/Work-around-internal-build-failure-by-adding-explicit-_WebKit_SwiftUI-import
remote: 
To https://github.com/emw-apple/WebKit.git
 * [new branch]                eng/Work-around-internal-build-failure-by-adding-explicit-_WebKit_SwiftUI-import -> eng/Work-around-internal-build-failure-by-adding-explicit-_WebKit_SwiftUI-import
Created 'PR 41009 | Work around internal build failure by adding explicit _WebKit_SwiftUI import'!
https://github.com/WebKit/WebKit/pull/41009
Added 'merge-queue' to 'PR 41009 | Work around internal build failure by adding explicit _WebKit_SwiftUI import', change is in the queue to be landed


and from yesterday:

> git webkit pr --no-add --no-rebase --draft
ERROR: WebKitLibraries/SDKs/macosx15.0-additions.sdk/usr/local/include/AvailabilityProhibitedInternal.h:57:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: WebKitLibraries/SDKs/macosx15.0-additions.sdk/usr/local/include/AvailabilityProhibitedInternal.h:58:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: WebKitLibraries/SDKs/macosx15.0-additions.sdk/usr/local/include/AvailabilityProhibitedInternal.h:59:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: WebKitLibraries/SDKs/macosx15.0-additions.sdk/usr/local/include/AvailabilityProhibitedInternal.h:60:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Total errors found: 4 in 1 files
style-checker failed!
Retry will amend the commit with your changes. Continue uploading pull request? (Yes/Retry/[No]): Retry
Total errors found: 0 in 1 files
Pushing to fork, which is classified as a public remote
Verifying commits in 'default' mode
Attempting to push 1 batch of commits to fork...
Verified 1 novel commit to fork are safe to push
Enumerating objects: 17, done.
Counting objects: 100% (17/17), done.
Delta compression using up to 10 threads
Compressing objects: 100% (6/6), done.
Writing objects: 100% (9/9), 1.62 KiB | 207.00 KiB/s, done.
Total 9 (delta 4), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (4/4), completed with 4 local objects.
remote: 
remote: Create a pull request for 'eng/Fix-availability-declaration-silencing-in-recent-SDKs' on GitHub by visiting:
remote:      https://github.com/emw-apple/WebKit/pull/new/eng/Fix-availability-declaration-silencing-in-recent-SDKs
remote: 
To https://github.com/emw-apple/WebKit.git
 * [new branch]                eng/Fix-availability-declaration-silencing-in-recent-SDKs -> eng/Fix-availability-declaration-silencing-in-recent-SDKs
Created 'PR 40938 | Fix availability declaration silencing in recent SDKs'!
Assigning associated issue to Elliott Williams <[e-mail]>
Posted pull request link to rdar://145186083
https://github.com/WebKit/WebKit/pull/40938

[Radar WebKit Bug Importer]

<rdar://problem/145594374>

[Brianna Fan]

Pull request: https://github.com/WebKit/WebKit/pull/41319

[EWS]

Committed 292453@main (bdfd10f2144a): <https://commits.webkit.org/292453@main>

Reviewed commits have been landed. Closing PR #41319 and removing active labels.