Bug 288055
| Summary: | [WebDriver] Fix switch_to_frame integer id parameter checks | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | WebDriver | Assignee: | Lauro Moura <lmoura> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bburg, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Lauro Moura
Test case: imported/w3c/webdriver/tests/classic/switch_to_frame/switch_number.py::test_frame_id_number_index_out_of_bounds[65535]
Currently, `Session::switchToFrame` has an assertion to check the boundary limits of an integer frame id parameter, which causes the whole WebDriver service to crash if out of range. According to the spec, we should return `invalid argument` instead:
https://w3c.github.io/webdriver/#switch-to-frame
> If id is less than 0 or greater than 2^16 – 1, return error with error code invalid argument.
Patch incoming.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/40948
EWS
Committed 290706@main (1b1b6513f5e6): <https://commits.webkit.org/290706@main>
Reviewed commits have been landed. Closing PR #40948 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/145218124>