Bug 287997
| Summary: | 4X imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-html.tentative.html?designMode=on&white-space= are flaky text failures | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Robert Jenner <jenner> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aboya, d_delatoba, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Robert Jenner
The following four tests are are flaky text failures on macOS:
imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-html.tentative.html?designMode=on&white-space=normal
imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-html.tentative.html?designMode=on&white-space=pre
imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-html.tentative.html?designMode=on&white-space=pre-line
imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-html.tentative.html?designMode=on&white-space=pre-wrap
At the filing of this bug these were occurring on wk1, wk2, Intel, and Apple Silicon Macs on Ventura and higher, and according to the history they have been flakes for a long time > 5000 commits back. Filing all of these together as they seem to be slightly different versions of the same test.
HISTORY:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fediting%2Fother%2Finsertparagraph-in-child-of-html.tentative.html%3FdesignMode%3Don%26white-space%3Dnormal&test=imported%2Fw3c%2Fweb-platform-tests%2Fediting%2Fother%2Finsertparagraph-in-child-of-html.tentative.html%3FdesignMode%3Don%26white-space%3Dpre&test=imported%2Fw3c%2Fweb-platform-tests%2Fediting%2Fother%2Finsertparagraph-in-child-of-html.tentative.html%3FdesignMode%3Don%26white-space%3Dpre-line&test=imported%2Fw3c%2Fweb-platform-tests%2Fediting%2Fother%2Finsertparagraph-in-child-of-html.tentative.html%3FdesignMode%3Don%26white-space%3Dpre-wrap&architecture=arm64
NORMAL DIFF:
https://build.webkit.org/results/Apple-Sequoia-Release-AppleSilicon-WK2-Tests/290604@main%20(1694)/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-html.tentative_designMode=on&white-space=normal-pretty-diff.html
-FAIL insertParagraph in empty <div style="white-space:normal"> after <body> should split the <div> assert_equals: The <div> should be split expected "<head><title>iframe</title></head><body><br></body><div style=\"white-space:normal\"><br></div><div style=\"white-space:normal\"><br></div>" but got "<head><title>iframe</title></head><body><br><div><br></div></body><div style=\"white-space:normal\"></div>"
+FAIL insertParagraph in empty <div style="white-space:normal"> after <body> should split the <div> assert_equals: The <div> should be split expected "<head><title>iframe</title></head><body><br></body><div style=\"white-space:normal\"><br></div><div style=\"white-space:normal\"><br></div>" but got "<head><title>iframe</title></head><body><br></body><div style=\"white-space:normal\"></div>"
PASS insertParagraph in <div style="white-space:normal"> (containing only a <br>) after <body> should split the <div>
PASS insertParagraph in <div style="white-space:normal"> (containing text) after <body> should not create another <div> element
FAIL insertParagraph in empty <div style="white-space:normal"> before <body> should split the <div> assert_equals: The <div> should be split expected "<head><title>iframe</title></head><div style=\"white-space:normal\"><br></div><div style=\"white-space:normal\"><br></div><body><br></body>" but got "<head><title>iframe</title></head><div style=\"white-space:normal\"></div><body><br><div><br></div></body>"
PRE DIFF:
https://build.webkit.org/results/Apple-Sequoia-Release-AppleSilicon-WK2-Tests/290618@main%20(1697)/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-html.tentative_designMode=on&white-space=pre-pretty-diff.html
-FAIL insertParagraph in empty <div style="white-space:pre"> after <body> should split the <div> assert_in_array: The <div> should be split value "<head><title>iframe</title></head><body><br><div><br></div></body><div style=\"white-space:pre\"></div>" not in array ["<head><title>iframe</title></head><body><br></body><div style=\"white-space:pre\">\n</div><div style=\"white-space:pre\">\n</div>", "<head><title>iframe</title></head><body><br></body><div style=\"white-space:pre\"><br></div><div style=\"white-space:pre\"><br></div>"]
+FAIL insertParagraph in empty <div style="white-space:pre"> after <body> should split the <div> assert_in_array: The <div> should be split value "<head><title>iframe</title></head><body><br></body><div style=\"white-space:pre\"></div>" not in array ["<head><title>iframe</title></head><body><br></body><div style=\"white-space:pre\">\n</div><div style=\"white-space:pre\">\n</div>", "<head><title>iframe</title></head><body><br></body><div style=\"white-space:pre\"><br></div><div style=\"white-space:pre\"><br></div>"]
PASS insertParagraph in <div style="white-space:pre"> (containing only a <br>) after <body> should split the <div>
PASS insertParagraph in <div style="white-space:pre"> (containing text) after <body> should not create another <div> element
FAIL insertParagraph in empty <div style="white-space:pre"> before <body> should split the <div> assert_in_array: The <div> should be split value "<head><title>iframe</title></head><div style=\"white-space:pre\"></div><body><br><div><br></div></body>" not in array ["<head><title>iframe</title></head><div style=\"white-space:pre\">\n</div><div style=\"white-space:pre\">\n</div><body><br></body>", "<head><title>iframe</title></head><div style=\"white-space:pre\"><br></div><div style=\"white-space:pre\"><br></div><body><br></body>"]
PRE-LINE DIFF
https://build.webkit.org/results/Apple-Sequoia-Release-AppleSilicon-WK2-Tests/290618@main%20(1697)/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-html.tentative_designMode=on&white-space=pre-line-pretty-diff.html
-FAIL insertParagraph in empty <div style="white-space:pre-line"> after <body> should split the <div> assert_in_array: The <div> should be split value "<head><title>iframe</title></head><body><br><div><br></div></body><div style=\"white-space:pre-line\"></div>" not in array ["<head><title>iframe</title></head><body><br></body><div style=\"white-space:pre-line\">\n</div><div style=\"white-space:pre-line\">\n</div>", "<head><title>iframe</title></head><body><br></body><div style=\"white-space:pre-line\"><br></div><div style=\"white-space:pre-line\"><br></div>"]
+FAIL insertParagraph in empty <div style="white-space:pre-line"> after <body> should split the <div> assert_in_array: The <div> should be split value "<head><title>iframe</title></head><body><br></body><div style=\"white-space:pre-line\"></div>" not in array ["<head><title>iframe</title></head><body><br></body><div style=\"white-space:pre-line\">\n</div><div style=\"white-space:pre-line\">\n</div>", "<head><title>iframe</title></head><body><br></body><div style=\"white-space:pre-line\"><br></div><div style=\"white-space:pre-line\"><br></div>"]
PASS insertParagraph in <div style="white-space:pre-line"> (containing only a <br>) after <body> should split the <div>
PASS insertParagraph in <div style="white-space:pre-line"> (containing text) after <body> should not create another <div> element
FAIL insertParagraph in empty <div style="white-space:pre-line"> before <body> should split the <div> assert_in_array: The <div> should be split value "<head><title>iframe</title></head><div style=\"white-space:pre-line\"></div><body><br><div><br></div></body>" not in array ["<head><title>iframe</title></head><div style=\"white-space:pre-line\">\n</div><div style=\"white-space:pre-line\">\n</div><body><br></body>", "<head><title>iframe</title></head><div style=\"white-space:pre-line\"><br></div><div style=\"white-space:pre-line\"><br></div><body><br></body>"]
PRE-WRAP DIFF:
https://build.webkit.org/results/Apple-Sequoia-Release-AppleSilicon-WK2-Tests/290618@main%20(1697)/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-html.tentative_designMode=on&white-space=pre-wrap-pretty-diff.html
-FAIL insertParagraph in empty <div style="white-space:pre-wrap"> after <body> should split the <div> assert_in_array: The <div> should be split value "<head><title>iframe</title></head><body><br><div><br></div></body><div style=\"white-space:pre-wrap\"></div>" not in array ["<head><title>iframe</title></head><body><br></body><div style=\"white-space:pre-wrap\">\n</div><div style=\"white-space:pre-wrap\">\n</div>", "<head><title>iframe</title></head><body><br></body><div style=\"white-space:pre-wrap\"><br></div><div style=\"white-space:pre-wrap\"><br></div>"]
+FAIL insertParagraph in empty <div style="white-space:pre-wrap"> after <body> should split the <div> assert_in_array: The <div> should be split value "<head><title>iframe</title></head><body><br></body><div style=\"white-space:pre-wrap\"></div>" not in array ["<head><title>iframe</title></head><body><br></body><div style=\"white-space:pre-wrap\">\n</div><div style=\"white-space:pre-wrap\">\n</div>", "<head><title>iframe</title></head><body><br></body><div style=\"white-space:pre-wrap\"><br></div><div style=\"white-space:pre-wrap\"><br></div>"]
PASS insertParagraph in <div style="white-space:pre-wrap"> (containing only a <br>) after <body> should split the <div>
PASS insertParagraph in <div style="white-space:pre-wrap"> (containing text) after <body> should not create another <div> element
FAIL insertParagraph in empty <div style="white-space:pre-wrap"> before <body> should split the <div> assert_in_array: The <div> should be split value "<head><title>iframe</title></head><div style=\"white-space:pre-wrap\"></div><body><br><div><br></div></body>" not in array ["<head><title>iframe</title></head><div style=\"white-space:pre-wrap\">\n</div><div style=\"white-space:pre-wrap\">\n</div><body><br></body>", "<head><title>iframe</title></head><div style=\"white-space:pre-wrap\"><br></div><div style=\"white-space:pre-wrap\"><br></div><body><br></body>"]
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/145164441>
Robert Jenner
I have been trivially been able to reproduce each of these test failures on macOS Sequoia Production ToT running the test as follows:
run-webkit-tests <Insert_Test_Here> --iterations 1000
I was able to reproduce the failures on average 3 times with each test running per 1000 iterations.
EWS
Test gardening commit 290642@main (dd6605004457): <https://commits.webkit.org/290642@main>
Reviewed commits have been landed. Closing PR #40894 and removing active labels.
Alicia Boya GarcĂa
The same flakiness occurs in the WPE and GTK bots, so this is unlikely to be platform specific. I'll move the expectations to the multi-platform TestExpectations.
The bot gtk-release completed 944 runs on the interval [302277@main-306273@main]
Frecuency of results for test: imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative.html?designMode=on&white-space=normal
181 times [19.2%] -> TEXT PASS
736 times [78.0%] -> NOERROR
27 times [2.9%] -> TEXT
Of those 944 runs it didn't match the expectation 208 times [22.0%]
Details of the type and frequency of unmatched expectations:
181 times [19.2%] -> TEXT PASS (Expected: PASS)
27 times [2.9%] -> TEXT (Expected: PASS)
Flakiness factor: 37.2%
- This test was flaky on 37.2% of the 944 runs analyzed, either giving different
results within a single run, or a different result than in the previous run.
Diego De La Toba
Gardening was moved to multi-platform TestExpectations with a type 306295@main. I am going to adjust these test expectations.
Diego De La Toba
Pull request: https://github.com/WebKit/WebKit/pull/59349
Diego De La Toba
(In reply to Diego De La Toba from comment #5)
> Gardening was moved to multi-platform TestExpectations with a type
> 306295@main. I am going to adjust these test expectations.
with a typo*
EWS
Test gardening commit 308144@main (e6e8f2f7b623): <https://commits.webkit.org/308144@main>
Reviewed commits have been landed. Closing PR #59349 and removing active labels.
Diego De La Toba
Correction they were added correctly here but the wrong expectations were removed from https://bugs.webkit.org/show_bug.cgi?id=289276
Diego De La Toba
Pull request: https://github.com/WebKit/WebKit/pull/59352
EWS
Test gardening commit 308146@main (da4f3936ba19): <https://commits.webkit.org/308146@main>
Reviewed commits have been landed. Closing PR #59352 and removing active labels.