Bug 28791

Summary: [Chromium] Space bar and enter should open drop-down menus on Linux
Product: WebKit Reporter: Albert Bachand <albertb>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jmalonzo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
URL: http://code.google.com/p/chromium/issues/detail?id=17159
Attachments:
Description Flags
Look for PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(LINUX)) when deciding whether to use the GTK behavior.
eric: review-
Look for PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(LINUX)) when deciding whether to use the GTK behavior. none

Albert Bachand
Reported 2009-08-27 17:12:32 PDT
Since PLATFORM(GTK) isn't defined in Chromium, Space/Enter don't open dropdown menus even though we're running under GTK.
Attachments
Look for PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(LINUX)) when deciding whether to use the GTK behavior. (1.33 KB, patch)
2009-08-27 17:15 PDT, Albert Bachand 		eric: review-
DetailsFormatted DiffDiff
Look for PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(LINUX)) when deciding whether to use the GTK behavior. (2.24 KB, patch)
2009-09-03 10:16 PDT, Albert Bachand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Albert Bachand
Comment 1 2009-08-27 17:15:08 PDT
Created attachment 38703 [details] Look for PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(LINUX)) when deciding whether to use the GTK behavior.
Eric Seidel (no email)
Comment 2 2009-08-31 03:37:18 PDT
Comment on attachment 38703 [details] Look for PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(LINUX)) when deciding whether to use the GTK behavior. Change looks good. ChangeLog was generated with funny paths, not sure why. We need at least a manual test for this: WebCore/manual-tests/ An automated test in LayoutTests/ would be better. It's definitely possible to send a space key event using eventSender, I'm not sure if it's possible to detect that a popup opened up from JavaScript though.
Jan Alonzo
Comment 3 2009-08-31 03:57:11 PDT
(In reply to comment #2) > (From update of attachment 38703 [details]) > Change looks good. ChangeLog was generated with funny paths, not sure why. > > We need at least a manual test for this: WebCore/manual-tests/ The manual test WebCore/manual-tests/select-popup-on-spacebar.html should already test for this. It may need Chromium-specific text there though.
Albert Bachand
Comment 4 2009-09-03 10:16:51 PDT
Created attachment 38995 [details] Look for PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(LINUX)) when deciding whether to use the GTK behavior. Updated the text of the test and fixed the funny paths in the ChangeLog.
Eric Seidel (no email)
Comment 5 2009-09-04 01:24:59 PDT
Comment on attachment 38995 [details] Look for PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(LINUX)) when deciding whether to use the GTK behavior. LGTM.
Eric Seidel (no email)
Comment 6 2009-09-04 01:40:44 PDT
Comment on attachment 38995 [details] Look for PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(LINUX)) when deciding whether to use the GTK behavior. Clearing flags on attachment: 38995 Committed r48044: <http://trac.webkit.org/changeset/48044>
Eric Seidel (no email)
Comment 7 2009-09-04 01:40:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.