| Summary: | [Chromium] Space bar and enter should open drop-down menus on Linux | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Albert Bachand <albertb> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | eric, jmalonzo |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| URL: | http://code.google.com/p/chromium/issues/detail?id=17159 | ||
| Attachments: | |||
|
Description
Albert Bachand
2009-08-27 17:12:32 PDT
Created attachment 38703 [details]
Look for PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(LINUX)) when deciding whether to use the GTK behavior.
Comment on attachment 38703 [details]
Look for PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(LINUX)) when deciding whether to use the GTK behavior.
Change looks good. ChangeLog was generated with funny paths, not sure why.
We need at least a manual test for this: WebCore/manual-tests/
An automated test in LayoutTests/ would be better. It's definitely possible to send a space key event using eventSender, I'm not sure if it's possible to detect that a popup opened up from JavaScript though.
(In reply to comment #2) > (From update of attachment 38703 [details]) > Change looks good. ChangeLog was generated with funny paths, not sure why. > > We need at least a manual test for this: WebCore/manual-tests/ The manual test WebCore/manual-tests/select-popup-on-spacebar.html should already test for this. It may need Chromium-specific text there though. Created attachment 38995 [details]
Look for PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(LINUX)) when deciding whether to use the GTK behavior.
Updated the text of the test and fixed the funny paths in the ChangeLog.
Comment on attachment 38995 [details]
Look for PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(LINUX)) when deciding whether to use the GTK behavior.
LGTM.
Comment on attachment 38995 [details] Look for PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(LINUX)) when deciding whether to use the GTK behavior. Clearing flags on attachment: 38995 Committed r48044: <http://trac.webkit.org/changeset/48044> All reviewed patches have been landed. Closing bug. |