Bug 28780

Summary:

dataTransfer.types() should include type "Files" when files are present in the clipboard.

Product:

WebKit

Reporter:

noel gordon <noel.gordon>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Add dataTransfer mime type "Files" to the chromium port.	eric: review-
First whack at a mac implementation (with some cleanup)	none
Add dataTransfer.types "Files" test for all ports.	none
Combine mac and chromium patches. Report PASS/FAIL for "Files" test cases.	eric: review-, eric: commit-queue-
Remove unintentional change.	none

noel gordon

Reported 2009-08-27 12:14:14 PDT

Per http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-August/021919.html, when files are present in the clipboard, the mime type report by .types() shall include the value "Files".

Attachments
Add dataTransfer mime type "Files" to the chromium port. (1.24 KB, patch) 2009-08-27 12:25 PDT, noel gordon	eric: review-	Details Formatted Diff Diff
First whack at a mac implementation (with some cleanup) (5.36 KB, patch) 2009-08-27 14:19 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Add dataTransfer.types "Files" test for all ports. (4.77 KB, patch) 2009-08-27 15:25 PDT, noel gordon	no flags	Details Formatted Diff Diff
Combine mac and chromium patches. Report PASS/FAIL for "Files" test cases. (15.17 KB, patch) 2009-08-27 16:34 PDT, noel gordon	eric: review- eric: commit-queue-	Details Formatted Diff Diff
Remove unintentional change. (14.76 KB, patch) 2009-08-27 17:38 PDT, noel gordon	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

noel gordon

Comment 1 2009-08-27 12:25:12 PDT

Created attachment 38678 [details] Add dataTransfer mime type "Files" to the chromium port.

Eric Seidel (no email)

Comment 2 2009-08-27 13:32:31 PDT

Comment on attachment 38678 [details] Add dataTransfer mime type "Files" to the chromium port. This type of change needs a test.

Eric Seidel (no email)

Comment 3 2009-08-27 14:19:57 PDT

Created attachment 38686 [details] First whack at a mac implementation (with some cleanup)

noel gordon

Comment 4 2009-08-27 15:25:44 PDT

Created attachment 38692 [details] Add dataTransfer.types "Files" test for all ports.

noel gordon

Comment 5 2009-08-27 15:26:56 PDT

(In reply to comment #2) > This type of change needs a test. tests added, tired your patch mac patch with this test too, all's well.

noel gordon

Comment 6 2009-08-27 16:34:25 PDT

Created attachment 38695 [details] Combine mac and chromium patches. Report PASS/FAIL for "Files" test cases.

Eric Seidel (no email)

Comment 7 2009-08-27 17:24:15 PDT

Comment on attachment 38695 [details] Combine mac and chromium patches. Report PASS/FAIL for "Files" test cases. LGTM.

Eric Seidel (no email)

Comment 8 2009-08-27 17:25:47 PDT

Comment on attachment 38695 [details] Combine mac and chromium patches. Report PASS/FAIL for "Files" test cases. Unintentional change: - NSArray *absoluteURLs = absoluteURLsFromPasteboardFilenames(m_pasteboard.get()); + NSArray *absoluteURLs = absoluteURLsFromPasteboard(m_pasteboard.get());

noel gordon

Comment 9 2009-08-27 17:38:45 PDT

Created attachment 38704 [details] Remove unintentional change.

Eric Seidel (no email)

Comment 10 2009-08-27 17:40:47 PDT

Comment on attachment 38704 [details] Remove unintentional change. LGTM.

Eric Seidel (no email)

Comment 11 2009-08-27 18:38:21 PDT

Comment on attachment 38704 [details] Remove unintentional change. Clearing flags on attachment: 38704 Committed r47852: <http://trac.webkit.org/changeset/47852>

Eric Seidel (no email)

Comment 12 2009-08-27 18:38:24 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.