Summary: | dataTransfer.types() should include type "Files" when files are present in the clipboard. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | noel gordon <noel.gordon> | ||||||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | eric | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | PC | ||||||||||||||
OS: | OS X 10.5 | ||||||||||||||
Attachments: |
|
Description
noel gordon
2009-08-27 12:14:14 PDT
Created attachment 38678 [details]
Add dataTransfer mime type "Files" to the chromium port.
Comment on attachment 38678 [details]
Add dataTransfer mime type "Files" to the chromium port.
This type of change needs a test.
Created attachment 38686 [details]
First whack at a mac implementation (with some cleanup)
Created attachment 38692 [details]
Add dataTransfer.types "Files" test for all ports.
(In reply to comment #2) > This type of change needs a test. tests added, tired your patch mac patch with this test too, all's well. Created attachment 38695 [details]
Combine mac and chromium patches. Report PASS/FAIL for "Files" test cases.
Comment on attachment 38695 [details]
Combine mac and chromium patches. Report PASS/FAIL for "Files" test cases.
LGTM.
Comment on attachment 38695 [details]
Combine mac and chromium patches. Report PASS/FAIL for "Files" test cases.
Unintentional change:
- NSArray *absoluteURLs = absoluteURLsFromPasteboardFilenames(m_pasteboard.get());
+ NSArray *absoluteURLs = absoluteURLsFromPasteboard(m_pasteboard.get());
Created attachment 38704 [details]
Remove unintentional change.
Comment on attachment 38704 [details]
Remove unintentional change.
LGTM.
Comment on attachment 38704 [details] Remove unintentional change. Clearing flags on attachment: 38704 Committed r47852: <http://trac.webkit.org/changeset/47852> All reviewed patches have been landed. Closing bug. |