Bug 28780

Summary: dataTransfer.types() should include type "Files" when files are present in the clipboard.
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Add dataTransfer mime type "Files" to the chromium port.
eric: review-
First whack at a mac implementation (with some cleanup)
none
Add dataTransfer.types "Files" test for all ports.
none
Combine mac and chromium patches. Report PASS/FAIL for "Files" test cases.
eric: review-, eric: commit-queue-
Remove unintentional change. none

Description noel gordon 2009-08-27 12:14:14 PDT
Per http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-August/021919.html,
when files are present in the clipboard, the mime type report by .types() shall
include the value "Files".
Comment 1 noel gordon 2009-08-27 12:25:12 PDT
Created attachment 38678 [details]
Add dataTransfer mime type "Files" to the chromium port.
Comment 2 Eric Seidel (no email) 2009-08-27 13:32:31 PDT
Comment on attachment 38678 [details]
Add dataTransfer mime type "Files" to the chromium port.

This type of change needs a test.
Comment 3 Eric Seidel (no email) 2009-08-27 14:19:57 PDT
Created attachment 38686 [details]
First whack at a mac implementation (with some cleanup)
Comment 4 noel gordon 2009-08-27 15:25:44 PDT
Created attachment 38692 [details]
Add dataTransfer.types "Files" test for all ports.
Comment 5 noel gordon 2009-08-27 15:26:56 PDT
(In reply to comment #2)
> This type of change needs a test.

tests added, tired your patch mac patch with this test too, all's well.
Comment 6 noel gordon 2009-08-27 16:34:25 PDT
Created attachment 38695 [details]
Combine mac and chromium patches. Report PASS/FAIL for "Files" test cases.
Comment 7 Eric Seidel (no email) 2009-08-27 17:24:15 PDT
Comment on attachment 38695 [details]
Combine mac and chromium patches. Report PASS/FAIL for "Files" test cases.

LGTM.
Comment 8 Eric Seidel (no email) 2009-08-27 17:25:47 PDT
Comment on attachment 38695 [details]
Combine mac and chromium patches. Report PASS/FAIL for "Files" test cases.

Unintentional change:
-    NSArray *absoluteURLs = absoluteURLsFromPasteboardFilenames(m_pasteboard.get());
+    NSArray *absoluteURLs = absoluteURLsFromPasteboard(m_pasteboard.get());
Comment 9 noel gordon 2009-08-27 17:38:45 PDT
Created attachment 38704 [details]
Remove unintentional change.
Comment 10 Eric Seidel (no email) 2009-08-27 17:40:47 PDT
Comment on attachment 38704 [details]
Remove unintentional change.

LGTM.
Comment 11 Eric Seidel (no email) 2009-08-27 18:38:21 PDT
Comment on attachment 38704 [details]
Remove unintentional change.

Clearing flags on attachment: 38704

Committed r47852: <http://trac.webkit.org/changeset/47852>
Comment 12 Eric Seidel (no email) 2009-08-27 18:38:24 PDT
All reviewed patches have been landed.  Closing bug.