Bug 287784 – Using WebSocket in a WebWorker can cause the entire Worker to freeze

• Component: Page Loading
• Status: RESOLVED FIXED

Created attachment 474243 [details]
This demo can be stably reproduced on some machines

Using WebSocket in a WebWorker can cause the entire Worker to freeze. By viewing the WebKit code, it was found that if the server disconnects while the client WebSocket is sending data, the send operation may get blocked, causing the Worker to become unresponsive.


 void WorkerThreadableWebSocketChannel::Peer::send(CString&& message)
 {
     ASSERT(isMainThread());
-    if (!m_mainWebSocketChannel)
-        return;
-
-    ThreadableWebSocketChannel::SendResult sendRequestResult = m_mainWebSocketChannel->send(WTFMove(message));
+    ThreadableWebSocketChannel::SendResult sendRequestResult =  ThreadableWebSocketChannel::SendResult::SendFail;
+
+    if (!m_mainWebSocketChannel){
+        printf("<<<<< WebSocketChannel::Peer::send m_mainWebSocketChannel is null   peer %p , workerClientWrapper %p \n ",this,m_workerClientWrapper.ptr());
+        // If it returns directly here, WebSocket send will be blocked.
+        // return;
+    }else{
+       sendRequestResult = m_mainWebSocketChannel->send(WTFMove(message));
+    }
    ScriptExecutionContext::postTaskForModeToWorkerOrWorklet(m_workerContextIdentifier, [workerClientWrapper = m_workerClientWrapper, sendRequestResult](ScriptExecutionContext&) mutable {
        workerClientWrapper->setSendRequestResult(sendRequestResult);
    }, m_taskMode);
}

Any comments?

[Radar WebKit Bug Importer]

<rdar://problem/145149784>

Created attachment 474306 [details]
worker websocket test demo

update demo

Created attachment 474307 [details]
test result

[EWS]

Committed 290802@main (502bfe7b3124): <https://commits.webkit.org/290802@main>

Reviewed commits have been landed. Closing PR #40972 and removing active labels.

[EWS]

Committed 289651.422@safari-7621-branch (1ad118aeb3f3): <https://commits.webkit.org/289651.422@safari-7621-branch>

Reviewed commits have been landed. Closing PR #2984 and removing active labels.