Bug 287767
| Summary: | [scroll-animations] refactor code related to `animation-timeline` and `timeline-scope` out of `AnimationTimelinesController` | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> |
| Component: | Animations | Assignee: | Antoine Quint <graouts> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | graouts, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Antoine Quint
We've been adding a fair bit of code to `AnimationTimelinesController` since starting work on Scroll-driven Animations to support the `animation-timeline` and `timeline-scope` properties. Since there is almost no overlap between the pre-existing functionality of `AnimationTimelinesController` and the added code, it would make sense to split off this new code in a dedicated class.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Antoine Quint
Pull request: https://github.com/WebKit/WebKit/pull/40682
EWS
Committed 290462@main (801565e14227): <https://commits.webkit.org/290462@main>
Reviewed commits have been landed. Closing PR #40682 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/144951555>