Bug 28745

Summary: minor style correction and include fix for notifications
Product: WebKit Reporter: John Gregg <johnnyg>
Component: WebCore Misc.Assignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch for style & include
none
patch with more files
none
same patch, no tabs in ChangeLog levin: review+

Description John Gregg 2009-08-26 11:40:58 PDT
I was alerted to an incorrect styling of enum members in notifications, and finding a problem with throwError not being defined (unclear how or when that was broken).
Comment 1 John Gregg 2009-08-26 11:43:33 PDT
Created attachment 38626 [details]
patch for style & include
Comment 2 John Gregg 2009-08-26 11:50:08 PDT
Created attachment 38627 [details]
patch with more files

here's a patch with all the files!
Comment 3 John Gregg 2009-08-26 12:34:32 PDT
Created attachment 38632 [details]
same patch, no tabs in ChangeLog

tab to spaces in ChangeLog.
Comment 4 David Levin 2009-08-26 12:37:07 PDT
Comment on attachment 38632 [details]
same patch, no tabs in ChangeLog

> Index: WebCore/ChangeLog
> +2009-08-26  John Gregg  <johnnyg@google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        minor style correction and include fix for notifications
> +        https://bugs.webkit.org/show_bug.cgi?id=28745
> +
> +        No new tests. 

Typically you would explain why there are no new tests.

For example,
"No new functionality so no new tests."
Comment 5 David Levin 2009-08-26 13:14:35 PDT
Assigned to levin for landing.
Comment 6 David Levin 2009-08-26 13:48:57 PDT
Committed as http://trac.webkit.org/changeset/47793