Bug 287306
| Summary: | Using MTLStorageModeManaged builds on iOS in open source when it should not | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Wyrzykowski <mwyrzykowski> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mike Wyrzykowski
MTLStorageModeManaged is marked `API_UNAVAILABLE(ios)` (see MTLResource.h) but successfully compiles in EWS iOS.
However, this leads to the following build breaks (potentially incomplete list):
https://bugs.webkit.org/show_bug.cgi?id=271480
https://bugs.webkit.org/show_bug.cgi?id=287301
https://bugs.webkit.org/show_bug.cgi?id=287303
but no where in WebKit can I find MTLStorageModeManaged redefined. Seems like iOS EWS is either using the wrong header files or thinks it is building for macOS?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/144562693>
Mike Wyrzykowski
EWS appears to be building iOS open source builds with the wrong SDK or compiler options. The header file on the bot is correct, but it ignores API_UNAVAILABLE macro:
```
MTLStorageModeManaged API_AVAILABLE(macos(10.11), macCatalyst(13.0)) API_UNAVAILABLE(ios) = 1,
```
from MTLResource.h
Alexey Proskuryakov
I don't see any indication of it building anything wrong in https://s3-us-west-2.amazonaws.com/ews-archives.webkit.org/ios-18-arm64-release-compile-webkit/8cdf2d37-8912.txt, it certainly uses the iOS SDK and deployment target.
Mike Wyrzykowski
Seen again with https://bugs.webkit.org/show_bug.cgi?id=291508, watchOS EWS was green prior to landing but internal watchOS build fails to build