Bug 28729

Summary: build failure for Qt/Linux when WML is enabled
Product: WebKit Reporter: Charles Wei <charles.wei>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Critical CC: charles.wei, yong.li.webkit
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
this patch fixes the build failure of WML eric: review+, eric: commit-queue+

Charles Wei
Reported 2009-08-25 20:32:00 PDT
The WebKit build failure with WML enabled, which is introduced in revision 47688.
Attachments
this patch fixes the build failure of WML (2.21 KB, patch)
2009-08-25 20:45 PDT, Charles Wei 		eric: review+
eric: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Charles Wei
Comment 1 2009-08-25 20:45:27 PDT
Created attachment 38591 [details] this patch fixes the build failure of WML with revision 47688, it moves contructor of WMLElement from public to protected, and added a new static function member WMLElement::create(), this brings the build failure . This patch fixes the build failure.
Eric Seidel (no email)
Comment 2 2009-08-26 03:14:30 PDT
Comment on attachment 38591 [details] this patch fixes the build failure of WML LGTM.
Yong Li
Comment 3 2009-09-02 10:10:42 PDT
landed @ r47976
Yong Li
Comment 4 2009-09-02 10:11:08 PDT
commit-queue doesn't work for this patch
Note You need to log in before you can comment on or make changes to this bug.