Bug 28715

Summary: [chromium] Implement media volume slider for chromium
Product: WebKit Reporter: Hin-Chung Lam <hclam>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch + change log
none
patch + change log none

Hin-Chung Lam
Reported 2009-08-25 10:52:31 PDT
There should be a media volume slider implementation for chromium port.
Attachments
patch + change log (7.66 KB, patch)
2009-08-25 11:03 PDT, Hin-Chung Lam 		no flags
DetailsFormatted DiffDiff
patch + change log (7.18 KB, patch)
2009-08-25 11:13 PDT, Hin-Chung Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hin-Chung Lam
Comment 1 2009-08-25 11:03:02 PDT
Created attachment 38558 [details] patch + change log
Hin-Chung Lam
Comment 2 2009-08-25 11:13:38 PDT
Created attachment 38559 [details] patch + change log
Eric Seidel (no email)
Comment 3 2009-08-25 11:49:08 PDT
Comment on attachment 38559 [details] patch + change log Rejecting patch 38559 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None
Eric Seidel (no email)
Comment 4 2009-08-25 13:09:17 PDT
Comment on attachment 38559 [details] patch + change log The commit-queue/bugzilla-tool isn't smart enough to handle when someone commits between when it updates and when it's ready to land. I'll add this back for another go. Merge conflict during commit: Your file or directory 'WebCore/ChangeLog' is probably out-of-date: resource out of date; try updating at /usr/local/libexec/git-core//git-svn line 469
Eric Seidel (no email)
Comment 5 2009-08-25 13:40:22 PDT
Comment on attachment 38559 [details] patch + change log Clearing flags on attachment: 38559 Committed r47756: <http://trac.webkit.org/changeset/47756>
Eric Seidel (no email)
Comment 6 2009-08-25 13:40:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.