Bug 28715

Summary:

[chromium] Implement media volume slider for chromium

Product:

WebKit

Reporter:

Hin-Chung Lam <hclam>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch + change log	none
patch + change log	none

Description Hin-Chung Lam 2009-08-25 10:52:31 PDT

There should be a media volume slider implementation for chromium port.

Comment 1 Hin-Chung Lam 2009-08-25 11:03:02 PDT

Created attachment 38558 [details]
patch + change log

Comment 2 Hin-Chung Lam 2009-08-25 11:13:38 PDT

Created attachment 38559 [details]
patch + change log

Comment 3 Eric Seidel (no email) 2009-08-25 11:49:08 PDT

Comment on attachment 38559 [details]
patch + change log

Rejecting patch 38559 from commit-queue.  This patch will require manual commit.

Failed to run "['git', 'svn', 'dcommit']"  exit_code: 1  cwd: None

Comment 4 Eric Seidel (no email) 2009-08-25 13:09:17 PDT

Comment on attachment 38559 [details]
patch + change log

The commit-queue/bugzilla-tool isn't smart enough to handle when someone commits between when it updates and when it's ready to land.  I'll add this back for another go.

Merge conflict during commit: Your file or directory 'WebCore/ChangeLog' is probably out-of-date: resource out of date; try updating at /usr/local/libexec/git-core//git-svn line 469

Comment 5 Eric Seidel (no email) 2009-08-25 13:40:22 PDT

Comment on attachment 38559 [details]
patch + change log

Clearing flags on attachment: 38559

Committed r47756: <http://trac.webkit.org/changeset/47756>

Comment 6 Eric Seidel (no email) 2009-08-25 13:40:25 PDT

All reviewed patches have been landed.  Closing bug.