Bug 28711

Summary: Qt WebKit crash in QWebHistory::saveState()
Product: WebKit Reporter: Jędrzej Nowacki <jedrzej.nowacki>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ariya.hidayat
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Path to QWebHistory::clear() ariya.hidayat: review+

Jędrzej Nowacki
Reported 2009-08-25 08:11:46 PDT
Qt WebKit crash in QWebHistory::saveState() if history instance was created from empty QWebPage and loaded by QWebHistory::restoreState(). Example, this code cause crash: { QByteArray tmp = hist->saveState(); QWebPage* page2 = new QWebPage(this); QWebHistory* hist2 = page2->history(); for (unsigned i = 0; i < 5; i++){ hist2->restoreState(tmp); hist2->saveState(); } delete page2; } Of course, the application should not crash :-)
Attachments
Path to QWebHistory::clear() (5.24 KB, patch)
2009-08-25 08:20 PDT, Jędrzej Nowacki
ariya.hidayat: review+
Jędrzej Nowacki
Comment 1 2009-08-25 08:20:21 PDT
Created attachment 38546 [details] Path to QWebHistory::clear() QWebHistory::clear() shouldn't create empty entry (item) if QWebHistory::count()<1; Additional autotests were added.
Ariya Hidayat
Comment 2 2009-08-27 05:27:48 PDT
Note You need to log in before you can comment on or make changes to this bug.