Bug 287099 – Implement RegExp Modifiers

• Component: JavaScriptCore
• Status: RESOLVED FIXED

https://github.com/tc39/proposal-regexp-modifiers is in stage 4.

rdar://131580854

Pull request: https://github.com/WebKit/WebKit/pull/40064

[EWS]

Committed 289955@main (868302168e9b): <https://commits.webkit.org/289955@main>

Reviewed commits have been landed. Closing PR #40064 and removing active labels.

[Fujii Hironori]

Some tests are crashing after this change.

Regressions: Unexpected crashes (9)
  imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.https.any.html [ Crash ]
  imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.https.any.worker.html [ Crash ]
  inspector/formatting/formatting-javascript.html [ Crash ]
  jquery/attributes.html [ Crash ]

History:

  https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=jquery%2Fattributes.html&test=imported%2Fw3c%2Fweb-platform-tests%2FWebCryptoAPI%2Fimport_export%2Frsa_importKey.https.any.worker.html&test=imported%2Fw3c%2Fweb-platform-tests%2FWebCryptoAPI%2Fimport_export%2Frsa_importKey.https.any.html&test=inspector%2Fformatting%2Fformatting-javascript.html


https://build.webkit.org/results/Apple-Ventura-Debug-AppleSilicon-WK1-Tests/289966@main%20(8757)/jquery/attributes-crash-log.txt

stderr:
ASSERTION FAILED: m_regs.regT2 != MacroAssembler::InvalidGPRReg
./yarr/YarrJIT.cpp(5097) : void JSC::Yarr::YarrGenerator<JSC::Yarr::YarrJITRegisters>::compileInline(JSC::Yarr::YarrBoyerMooreData &) [YarrJITRegs = JSC::Yarr::YarrJITRegisters]
1   0x1209710d0 JSC::Yarr::YarrGenerator<JSC::Yarr::YarrJITRegisters>::compileInline(JSC::Yarr::YarrBoyerMooreData&)
2   0x1209707b4 JSC::Yarr::jitCompileInlinedTest(WTF::StackCheck*, WTF::StringView, WTF::OptionSet<JSC::Yarr::Flags>, JSC::Yarr::CharSize, JSC::VM*, JSC::Yarr::YarrBoyerMooreData&, JSC::CCallHelpers&, JSC::Yarr::YarrJITRegisters&)
3   0x11e61558c JSC::DFG::SpeculativeJIT::compileRegExpTestInline(JSC::DFG::Node*)::$_21::operator()(JSC::ARM64Registers::RegisterID, JSC::AbstractMacroAssembler<JSC::ARM64Assembler>::JumpList&) const
4   0x11e6150a0 JSC::DFG::SpeculativeJIT::compileRegExpTestInline(JSC::DFG::Node*)
5   0x11e618a30 JSC::DFG::SpeculativeJIT::compile(JSC::DFG::Node*)
6   0x11e3e759c JSC::DFG::SpeculativeJIT::compileCurrentBlock()
7   0x11e3d3738 JSC::DFG::SpeculativeJIT::compileBody()
8   0x11e3d4df8 JSC::DFG::SpeculativeJIT::compileFunction()
9   0x11f7bae4c JSC::DFG::Plan::compileInThreadImpl()
10  0x11fcce8fc JSC::JITPlan::compileInThread(JSC::JITWorklistThread*)
11  0x11fd2a248 JSC::JITWorklistThread::work()
12  0x11e1ee374 WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0::operator()() const
13  0x11e1edf24 WTF::Detail::CallableWrapper<WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0, void>::call()
14  0x11e20cee0 WTF::Function<void ()>::operator()() const
15  0x11e353714 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*)
16  0x11e3600a0 WTF::wtfThreadEntryPoint(void*)
17  0x1aa403fa8 _pthread_start
18  0x1aa3feda0 thread_start

[Fujii Hironori]

Fixed by 290034@main.