| Summary: | Make possible to better use ResourceError in FrameLoaderClientQt class | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antonio Gomes <tonikitoo> | ||||
| Component: | WebKit Qt | Assignee: | Antonio Gomes <tonikitoo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | hausmann, kenneth | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
Created attachment 38542 [details]
patch 0.1 - replace m_loadSucceeded by m_loadError
Comment on attachment 38542 [details] patch 0.1 - replace m_loadSucceeded by m_loadError landed in r47746 clearing r+ flag |
currently we have only a bool class member that keeps track if the page has been successfuly loaded or not. see below: (...) bool m_loadSucceeded; (...) In practical terms, it is fired together with loadFinished(bool success). For a better use of error resources provided by WebCore, I would like to propose instead of have this single bool flag indicating a successful load, we to keep track of the whole ResourceError object that is passed in for FrameLoaderClientQt by WebCore, and that way we would be holding more information, including possibly the errorCode, the failing url, and so ... the attached patch replaces the use of 'bool m_loadSucceeded' by a 'ResourceError m_loadError' , although API is not changed (yet): we keep emiting the "bool success" w/ loadFinished signal. it also makes requestedUrl method to behavior more accurately, so this method body is also updated accordingly. all unit tests passed.