Bug 287001 – [GTK][WPE] Build fails with RELEASE_LOG=ON

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Adrian Perez]

Configuring a build with:

   % cmake -DPORT=WPE -DDEVELOPER_MODE=ON -DENABLE_RELEASE_LOG=ON  \
         -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja -Bbuilddir 

results in a number of build issues, most of them related to mismatched specifiers in format strings, e.g.

../Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:72:9: error: format specifies type 'unsigned long' but the argument has type 'unsigned long long' [-Werror,-Wformat]
   72 |         WebFrameLoaderClient_RELEASE_LOG_ERROR(WEBFRAMELOADERCLIENT_NAVIGATIONACTIONDATA_NO_WEBPAGE);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

and some issues related to direct usage of %{public}s in Linux where os_log()/os_trace() are not a thing, e.g.

../Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:353:99: error: using 'public' format specifier annotation outside of os_log()/os_trace() [-Werror,-Wformat]
  353 |         RELEASE_LOG(Process, "%p - PageConfiguration::delaysWebProcessLaunchUntilFirstLoad() -> %{public}s because of explicit client value", this, *m_data.delaysWebProcessLaunchUntilFirstLoad ? "true" : "false");
      |                                                                                                 ~~^~~~~~~~

[Adrian Perez]

Pull request: https://github.com/WebKit/WebKit/pull/39984

[EWS]

Committed 289784@main (9c17739ab025): <https://commits.webkit.org/289784@main>

Reviewed commits have been landed. Closing PR #39984 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/144158241>