Bug 286954
| Summary: | [Results DB] API responses aren't compressed | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | karlcow, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Sneddon [:gsnedders]
c.f. https://bugs.webkit.org/show_bug.cgi?id=286603#c2
Loading https://results.webkit.org/?flavor=wk1&recent=false&suite=layout-tests&test=fonts%2Ffont-weight-invalid-crash.html eventually downloads 65.9 MB, of which 65.8 MB is transferred over the wire.
There's little need for so much to be sent, and it's almost entirely uncompressed JSON. For example:
```
gsnedders@gsnedders-margot ~ % curl 'https://results.webkit.org/api/results/layout-tests/fonts/font-weight-invalid-crash.html?flavor=wk1&recent=false' \
-X 'GET' \
-H 'Accept: */*' \
-H 'Sec-Fetch-Site: same-origin' \
-H 'Referer: https://results.webkit.org/?flavor=wk1&recent=false&suite=layout-tests&test=fonts%2Ffont-weight-invalid-crash.html' \
-H 'Sec-Fetch-Dest: empty' \
-H 'Accept-Language: en-GB,en;q=0.9' \
-H 'Sec-Fetch-Mode: cors' \
-H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.2 Safari/605.1.15' \
-H 'Accept-Encoding: gzip, deflate, br' \
-H 'Connection: keep-alive' \
-H 'Priority: u=3, i' \
--verbose \
-o results-db.json
...
> GET /api/results/layout-tests/fonts/font-weight-invalid-crash.html?flavor=wk1&recent=false HTTP/1.1
> Host: results.webkit.org
> Accept: */*
> Sec-Fetch-Site: same-origin
> Referer: https://results.webkit.org/?flavor=wk1&recent=false&suite=layout-tests&test=fonts%2Ffont-weight-invalid-crash.html
> Sec-Fetch-Dest: empty
> Accept-Language: en-GB,en;q=0.9
> Sec-Fetch-Mode: cors
> User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.2 Safari/605.1.15
> Accept-Encoding: gzip, deflate, br
> Connection: keep-alive
> Priority: u=3, i
>
* Request completely sent off
0 0 0 0 0 0 0 0 --:--:-- 0:00:07 --:--:-- 0< HTTP/1.1 200 OK
< Server: Apple
< Date: Mon, 03 Feb 2025 21:10:39 GMT
< Content-Type: application/json
< Content-Length: 5665845
< Connection: keep-alive
< X-B3-TraceId: c2b608594ab41f05
< Strict-Transport-Security: max-age=31536000
< Strict-Transport-Security: max-age=31536000; includeSubdomains
< X-Frame-Options: SAMEORIGIN
< X-Content-Type-Options: nosniff
< X-XSS-Protection: 1; mode=block
<
{ [15996 bytes data]
100 5533k 100 5533k 0 0 477k 0 0:00:11 0:00:11 --:--:-- 1423k
* Connection #0 to host results.webkit.org left intact
gsnedders@gsnedders-margot ~ % gzip -k results-db.json
gsnedders@gsnedders-margot ~ % ls -lh results-db.json*
-rw-r--r-- 1 gsnedders staff 5.4M Feb 3 13:10 results-db.json
-rw-r--r-- 1 gsnedders staff 748K Feb 3 13:10 results-db.json.gz
```
This shows that there's big savings to be had in how much we're sending over the wire.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/144111656>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/55179
EWS
Committed 304252@main (b2f892e71e42): <https://commits.webkit.org/304252@main>
Reviewed commits have been landed. Closing PR #55179 and removing active labels.