Bug 286727
| Summary: | Drop use of WTF_ALLOW_UNSAFE_BUFFER_USAGE in CSSCalcTree+Parser.cpp | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | CSS | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | fujii, koivisto, rcaliman, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 286743, 286745 | ||
| Bug Blocks: | |||
Chris Dumez
Drop use of WTF_ALLOW_UNSAFE_BUFFER_USAGE in CSSCalcTree+Parser.cpp.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/39746
EWS
Committed 289546@main (a4af661503b7): <https://commits.webkit.org/289546@main>
Reviewed commits have been landed. Closing PR #39746 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/143867680>
Fujii Hironori
289546@main added "originalTokens[tokens.begin() - originalTokens.data() - 1]"
This expression accesses "originalTokens[-1]".
With MS STL + Debug build, the problem crashes.
> Debug Assertion Failed!
>
> Program: C:\webkit\wa\webkitbuild\debug\bin\WebCore.dll
> File: C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.42.34433\include\span
> Line: 454
>
> Expression: span index out of range
Can I revert this change?
Razvan Caliman
Revert in https://bugs.webkit.org/show_bug.cgi?id=286743
Chris Dumez
Reopened Bugzilla.
Unreviewed, revert 289546@main as it introduced crashes, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=286745.
Chris Dumez
Follow-up fix in https://commits.webkit.org/289558@main.