Bug 286575
| Summary: | Imperative invokers for popover doesn't fix focus order | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Luke Warlow <lwarlow> |
| Component: | DOM | Assignee: | Luke Warlow <lwarlow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ntim, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=282337 https://github.com/web-platform-tests/wpt/pull/50308 |
||
Luke Warlow
Imperative invoker relationships were recently added to the popover API (see https://bugs.webkit.org/show_bug.cgi?id=282337). However, it turns out there's missing test coverage for one of the required features, doing a focus fixup using the provided invoker. As a result this is missing from the WebKit impl (and Chromium's). This bug tracks addressing that.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tim Nguyen (:ntim)
This function just needs to be augmented to support the new way of setting the invoker:
https://searchfox.org/wubkat/rev/47b66cb0dc7c2146fa7576555c720080708667f3/Source/WebCore/page/FocusController.cpp#84-93
Lmk if you need help with that but I'm sure you can figure it out!
Luke Warlow
Thanks for the pointer! Yeah I actually already have a patch just about to push it up.
Luke Warlow
Pull request: https://github.com/WebKit/WebKit/pull/39598
Radar WebKit Bug Importer
<rdar://problem/144094678>
EWS
Committed 291719@main (b46f59f1c06a): <https://commits.webkit.org/291719@main>
Reviewed commits have been landed. Closing PR #39598 and removing active labels.