Bug 286441 – `run-minibrowser --ipad-simulator` fails ("Incompatible device")

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Sam Sneddon [:gsnedders]]

```
run-minibrowser --ipad-simulator
Unable to create a device for device type: iPad Pro (9.7-inch) (com.apple.CoreSimulator.SimDeviceType.iPad-Pro--9-7-inch-), runtime: iOS iOS 17.4 (17.4 - 21E213) - com.apple.CoreSimulator.SimRuntime.iOS-17-4
An error was encountered processing the command (domain=com.apple.CoreSimulator.SimError, code=403):
Incompatible device
Couldn't create simulator device: iPad Pro For WebKit Development com.apple.CoreSimulator.SimDeviceType.iPad-Pro--9-7-inch- com.apple.CoreSimulator.SimRuntime.iOS-17-4 at /Volumes/Data/Code/Safari/OpenSource/Tools/Scripts/webkitdirs.pm line 2041.
```

It's pretty obvious what the problem is:

```
% simctl list --json devicetypes  | jq '.devicetypes[] | select(.identifier == "com.apple.CoreSimulator.SimDeviceType.iPad-Pro--9-7-inch-")'
{
  "productFamily": "iPad",
  "bundlePath": "/Library/Developer/CoreSimulator/Profiles/DeviceTypes/iPad Pro (9.7-inch).simdevicetype",
  "maxRuntimeVersion": 1050880,
  "maxRuntimeVersionString": "16.9.0",
  "identifier": "com.apple.CoreSimulator.SimDeviceType.iPad-Pro--9-7-inch-",
  "modelIdentifier": "iPad6,4",
  "minRuntimeVersionString": "10.0.0",
  "minRuntimeVersion": 655360,
  "name": "iPad Pro (9.7-inch)"
}
```

We're trying to create an iPad Simulator with a device type that doesn't support the runtime we're requesting.

The device type used comes from `Tools/Scripts/webkitdirs.pm`, which was added in 224547@main (bug 211606).

This notably _doesn't match_ what `Tools/Scripts/webkitpy/port/ios_simulator.py` defines (used by `run-webkit-tests`, `run-api-tests`, etc.), which is run on CI and thus is something currently supported. This got added in 208076@main (iPad (5th generation)), changed in 259682@main (iPad (10th generation)), and most recently in 260904@main (iPad (9th generation)). This has never been an iPad Pro — so this has always differed.

We should probably keep these two in-sync.

[Radar WebKit Bug Importer]

<rdar://problem/143523453>

[Sam Sneddon [:gsnedders]]

Pull request: https://github.com/WebKit/WebKit/pull/39469

[EWS]

Committed 289336@main (26f8bc833e26): <https://commits.webkit.org/289336@main>

Reviewed commits have been landed. Closing PR #39469 and removing active labels.