Bug 286224

Summary: [Cleanup] De-virtualize RenderBox::avoidsFloats
Product: WebKit Reporter: alan <zalan>
Component: New BugsAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq]Patch none

alan
Reported 2025-01-18 19:05:40 PST
ssia
Attachments
Patch (6.42 KB, patch)
2025-01-18 19:14 PST, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (6.42 KB, patch)
2025-01-20 06:48 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2025-01-18 19:14:22 PST
Created attachment 473945 [details] Patch
alan
Comment 2 2025-01-20 06:48:40 PST
Created attachment 473957 [details] [fast-cq]Patch
EWS
Comment 3 2025-01-20 09:54:10 PST
Committed 289155@main (b288822437b9): <https://commits.webkit.org/289155@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 473957 [details].
Radar WebKit Bug Importer
Comment 4 2025-01-20 09:55:14 PST
<rdar://problem/143274441>
Ross Kirsling
Comment 5 2025-01-20 17:44:16 PST
This broke PlayStation port, as EWS would have shown; it presumably should not have been landed so quickly.
Ross Kirsling
Comment 6 2025-01-20 17:46:31 PST
Comment on attachment 473957 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=473957&action=review > Source/WebCore/rendering/RenderBox.cpp:5174 > - if (isReplacedOrAtomicInline() || isLegend() || isFieldset() || (element() && element()->isFormControlElement())) > + if (isReplacedOrAtomicInline() || isLegend() || (element() && element()->isFormControlElement()) || is<RenderMathMLBlock>(*this)) In particular, you can't do this without adding an ENABLE(MATHML) guard.
alan
Comment 7 2025-01-20 18:33:21 PST
Sorry about that. Thanks for fixing it.
Note You need to log in before you can comment on or make changes to this bug.