Bug 286163
| Summary: | [WebDriver][BiDi] Fix error response id, type, and error name fields | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | WebDriver | Assignee: | Lauro Moura <lmoura> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bburg, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Lauro Moura
The error response is missing a few bits:
- Attaching the command's "id" field in some `Message::fail` calls, so the client know what command caused the error response
- The "type" field, with value "error", mirroring the other types ("event", and "response")
- The "error" field is the JSON error name string, per https://w3c.github.io/webdriver/#dfn-error-code. Currently, we're sending the corresponding HTTP status code.
These are causing the `webdriver` WPT library to hang if the browser replies with an error.
Patch incoming.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/39207
Radar WebKit Bug Importer
<rdar://problem/143584030>
EWS
Committed 289728@main (faec608ad6c7): <https://commits.webkit.org/289728@main>
Reviewed commits have been landed. Closing PR #39207 and removing active labels.