Bug 28601

Summary:

bugzilla-tool post-commits posts commits backwards

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, eric, mrowe

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch v1	abarth: review+

Adam Barth

Reported 2009-08-20 22:39:08 PDT

See https://bugs.webkit.org/show_bug.cgi?id=24696

Attachments
Patch v1 (3.74 KB, patch) 2009-09-01 17:56 PDT, David Kilzer (:ddkilzer)	abarth: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2009-08-20 22:49:30 PDT

Committed as http://trac.webkit.org/changeset/47563

David Kilzer (:ddkilzer)

Comment 2 2009-08-20 22:50:44 PDT

(In reply to comment #1) > Committed as http://trac.webkit.org/changeset/47563 Please ignore this comment. It was meant for Bug 28485.

David Kilzer (:ddkilzer)

Comment 3 2009-08-20 22:53:15 PDT

I think this change to scm.py fixes that: elif '..' in commitish: - commit_ids += self.run_command(['git', 'rev-list', commitish]).splitlines() + commit_ids += reversed(self.run_command(['git', 'rev-list', commitish]).splitlines())

Adam Barth

Comment 4 2009-08-20 22:56:29 PDT

> I think this change to scm.py fixes that: Cool! Now we just need a unittest. :)

David Kilzer (:ddkilzer)

Comment 5 2009-09-01 17:56:55 PDT

Created attachment 38903 [details] Patch v1

Adam Barth

Comment 6 2009-09-01 18:07:58 PDT

Comment on attachment 38903 [details] Patch v1 Awesome. :)

David Kilzer (:ddkilzer)

Comment 7 2009-09-01 19:27:22 PDT

Committed r47953: <http://trac.webkit.org/changeset/47953>

Note You need to log in before you can comment on or make changes to this bug.