Bug 285736
| Summary: | [CoordinatedGraphics] Wait for tile buffers to be rendered before painting to texture mapper | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> |
| Component: | Platform | Assignee: | Carlos Garcia Campos <cgarcia> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, magomez, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Garcia Campos
In 288158@main I moved the tiles updates processing to CoordinatedBackingStore::paintToTextureMapper(), but it can happen that the layer paint is skipped. We should always wait for buffers in the composition to make sure there aren't painting thread running after the composition.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/38835
Miguel Gomez
We shouldn't be processing the tile changes just before painting them. We should do it before, so they may be already uploaded to textures when we want to use them. As it was done before, the tiles would be uploaded while we were doing other operations, tree traversals, or painting other tiles, so we may have them ready for painting as soon as we need them. With the approach of processing the changes in paintToTextureMapper, we always have to wait for each tile to be uploaded before we can actually paint it, which is less efficient.
EWS
Committed 288695@main (f67a8f0bac71): <https://commits.webkit.org/288695@main>
Reviewed commits have been landed. Closing PR #38835 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/142681654>