Bug 285640
| Summary: | Regression(288466@main) ASSERT(valueLength > 0) is hit in parseParameterValue() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Dumez
In 288466@main, I updated LinkHeader.cpp's parseParameterValue() to address unsafe buffer warnings.
One of the changes made was to stop using pointer arithmetics and use an index in the span instead.
However, I made a mistake and converted this assertion:
```
ASSERT(valueEnd >= valueStart);
```
into
```
ASSERT(valueLength > 0);
```
instead of:
```
ASSERT(valueLength >= 0)
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
<rdar://142559962>
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/38756
EWS
Committed 288635@main (25cee58a0e3b): <https://commits.webkit.org/288635@main>
Reviewed commits have been landed. Closing PR #38756 and removing active labels.