Bug 285620
| Summary: | Revert use of separate megapage heap in libpas | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Degazio <d_degazio> |
| Component: | bmalloc | Assignee: | David Degazio <d_degazio> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ggaren, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Degazio
https://bugs.webkit.org/show_bug.cgi?id=284338 introduced the notion of a megapage large heap per pas_heap, letting us allocate megapages for small/medium objects out of a distinct space from other large objects. Unfortunately this seems to have regressed HashSet-wasm startup in JetStream 2 by 10-20%, seemingly just due to the additional page faults we get from setting up these new heaps. Let's revert this for now, but add a profiling hook to measure how often this happens to revisit enabling this in the future.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/142561181>
David Degazio
Pull request: https://github.com/WebKit/WebKit/pull/38737
EWS
Committed 288613@main (6bed96b90169): <https://commits.webkit.org/288613@main>
Reviewed commits have been landed. Closing PR #38737 and removing active labels.