Bug 285547

Summary:	Fix missing popFloat64's in IPInt and re-enable IPInt
Product:	WebKit	Reporter:	daniel_liu4
Component:	JavaScriptCore	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	benjamin.j.grant, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

daniel_liu4

Reported 2025-01-07 12:27:25 PST

IPInt truncation opcodes previously did not pop the necessary value from the stack (due to a missing popFloat64 during https://commits.webkit.org/280730@main in f64 truncation operations). This led to the issues mentioned in https://bugs.webkit.org/show_bug.cgi?id=285535. Adding these instructions fixes the issues encountered. With this fix, we can re-enable IPInt.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2025-01-07 12:27:37 PST

<rdar://problem/142496259>

daniel_liu4

Comment 2 2025-01-07 12:28:43 PST

Pull request: https://github.com/WebKit/WebKit/pull/38668

EWS

Comment 3 2025-01-07 13:46:01 PST

Committed 288560@main (f5f34b0db59c): <https://commits.webkit.org/288560@main> Reviewed commits have been landed. Closing PR #38668 and removing active labels.

Alexey Proskuryakov

Comment 4 2025-01-07 16:05:40 PST

*** Bug 285466 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.