Bug 285295

Summary:

[view-transitions] animation-name set from user agent dynamic stylesheet has extra quotes

Product:

WebKit

Reporter:

martrapp <martrapp>

Component:

New Bugs

Assignee:

Tim Nguyen (:ntim) <ntim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ntim, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari 18

Hardware:

All

OS:

iOS 18

See Also:

https://github.com/web-platform-tests/wpt/pull/49894

Attachments:

Description	Flags
minimal reproduction that logs the names with quotes	none
Entry page to test page	none

martrapp@gmx.net

Reported 2025-01-02 03:25:01 PST

Created attachment 473742 [details] minimal reproduction that logs the names with quotes View transition animation names from the user agent stylesheet like -ua-view-transition-group-anim-body are reported with additional quotes by getComputedStyle(), e.g. "-ua-view-transition-group-anim-body".

Attachments
minimal reproduction that logs the names with quotes (827 bytes, text/html) 2025-01-02 03:25 PST, martrapp@gmx.net	no flags	Details
Entry page to test page (96 bytes, text/html) 2025-01-02 18:57 PST, Tim Nguyen (:ntim)	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Tim Nguyen (:ntim)

Comment 1 2025-01-02 18:57:14 PST Comment hidden (obsolete)

Created attachment 473757 [details] Entry page to test page

Tim Nguyen (:ntim)

Comment 2 2025-01-02 19:27:11 PST

The string serialization is technically not invalid, since `animation-name` accepts both a `<custom-ident>` and a `<string>` (and they are both equivalent in terms of functionality, except for restricted idents) but I suppose it's possible to align with Chrome here.

Radar WebKit Bug Importer

Comment 3 2025-01-02 20:19:34 PST

<rdar://problem/142298840>

Tim Nguyen (:ntim)

Comment 4 2025-01-02 20:26:07 PST Comment hidden (obsolete)

Pull request: https://github.com/WebKit/WebKit/pull/38484

Tim Nguyen (:ntim)

Comment 5 2025-01-02 20:26:26 PST

Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/49894

martrapp@gmx.net

Comment 6 2025-01-02 23:48:17 PST

Thank you for considering this!

Tim Nguyen (:ntim)

Comment 7 2025-01-03 10:31:32 PST

Pull request: https://github.com/WebKit/WebKit/pull/38501

EWS

Comment 8 2025-01-03 13:50:20 PST

Committed 288417@main (f0baf504e518): <https://commits.webkit.org/288417@main> Reviewed commits have been landed. Closing PR #38501 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.