Bug 285270
| Summary: | Fix WritingMode::isLineInverted to return correctly for sideways-lr | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | fantasai <fantasai.bugs> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 166941 | ||
fantasai
The logic in WritingMode::isLineInverted fails to account for `writing-mode: sideways-lr` since it fails to distinguish between `vertical-lr` and `sideways-lr`.
Also we should be using it in `BoxGeometryUpdater::formattingContextConstraints` where we're incorrectly checking isBlockFlipped() instead.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/142223524>
fantasai
https://github.com/WebKit/WebKit/pull/38446
EWS
Committed 288371@main (f4b48e25beae): <https://commits.webkit.org/288371@main>
Reviewed commits have been landed. Closing PR #38446 and removing active labels.