Bug 285220

Summary:	Move GCC_WARN_NON_VIRTUAL_DESTRUCTOR to CommonBase.xcconfig
Product:	WebKit	Reporter:	David Kilzer (:ddkilzer) <ddkilzer>
Component:	New Bugs	Assignee:	David Kilzer (:ddkilzer) <ddkilzer>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

David Kilzer (:ddkilzer)

Reported 2024-12-28 11:07:17 PST

Move GCC_WARN_NON_VIRTUAL_DESTRUCTOR Xcode build setting to CommonBase.xcconfig. This enables -Wnon-virtual-dtor for the first time on some projects under Tools, which need changes to fix compile errors.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-12-28 11:07:37 PST

<rdar://problem/142127164>

David Kilzer (:ddkilzer)

Comment 2 2024-12-28 11:22:17 PST

Pull request: https://github.com/WebKit/WebKit/pull/38409

EWS

Comment 3 2024-12-30 11:13:14 PST

Committed 288332@main (0b8e5ea6809c): <https://commits.webkit.org/288332@main> Reviewed commits have been landed. Closing PR #38409 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.