Bug 284976
| Summary: | Add a feature flag for remote snapshotting | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=284427 | ||
| Bug Depends on: | |||
| Bug Blocks: | 282664 | ||
Said Abou-Hallawa
Currently snapshotting a page to an image or a PDFDocument has to go through this IPC workflow: UIProcess -> WebProcess -> UIProcess. After 288113@main and with site isolation enabled, snapshotting will go through the following IPC workflow: UIProcess -> WebProcess -> GPUProcess -> UIProcess. So any WebProcess can't see the drawing of the other WebProcesses.
To address the review comment https://github.com/WebKit/WebKit/pull/37756#discussion_r1891010340, a new feature flag will be introduced to allow testing the remote snapshotting separate from the site isolation. If site isolation is enabled, the main frame has to compose itself with all the remote iframes to get the correct snapshotting. This will be done in future patches.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/141783206>
Radar WebKit Bug Importer
<rdar://problem/141783279>
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/38228
Said Abou-Hallawa
Committed 288504@main (d9f35fa): https://commits.webkit.org/288504@main
Reviewed commits have been landed. Closing PR #38228 and removing active labels.