Bug 284938
| Summary: | Only synthesize a 'viewBox' in <img> for the document element <svg> | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | SVG | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
This is just plain merge of below:
Blink Commit: https://chromium.googlesource.com/chromium/src/+/b895b95cbe1718e0492cec48a398e90d26049ed3
WebKit Source: https://searchfox.org/wubkat/rev/d46c14cf9008c4385cf0ac7919561b278d047e85/Source/WebCore/svg/SVGSVGElement.cpp#590
WPT Test: http://wpt.live/svg/embedded/image-embedding-svg-nested-svg-in-foreignobject.html
****
auto isEmbeddedThroughSVGImage = [this](const RenderElement* renderer) -> bool {
bool isDocumentElement = document().documentElement() == this;
if (!isDocumentElement)
return false;
****
This fix failing test case. So raising so we can fix it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/141733733>
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/38195
EWS
Committed 288134@main (257fce338020): <https://commits.webkit.org/288134@main>
Reviewed commits have been landed. Closing PR #38195 and removing active labels.