Bug 284860
| Summary: | Some images on www.dandelionchocolate.com fail to load | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Woodrow <mattwoodrow> |
| Component: | Layout and Rendering | Assignee: | Matt Woodrow <mattwoodrow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Matt Woodrow
<rdar://141520514>
This is a bad interaction between the 284780@main changes, and the old ‘simplified repaint’ optimisation.
A style change that results in a compositing layer being created/destroyed previously wrote new ‘repaint rects’ onto the RenderLayer. There was a comment complaining about this, as computing repaint rects while layout was dirty was invalid.
The new code in 284780@main just sets the dirty bit on the layer, so that we know to recompute repaint rects after the next layout.
If that next layout ends up being a ‘simplified’ one, then the simplified repaint optimisations applied to the layer positions update and stop the repaint rects from being computed.
The simplified repaint optimisation isn’t valid when dirty bits are set outside of the layout immediately preceding the layer position update.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Matt Woodrow
Pull request: https://github.com/WebKit/WebKit/pull/38117
EWS
Committed 288074@main (5dda919ecebd): <https://commits.webkit.org/288074@main>
Reviewed commits have been landed. Closing PR #38117 and removing active labels.