Bug 284843
| Summary: | Drop mock dependency | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=294864 | ||
Sam Sneddon [:gsnedders]
mock provides a backport of https://docs.python.org/3/library/unittest.mock.html
Now we're only Python 3.9 and later, there's no need to rely on the backport — and we should consider carefully where we might want to in future, should need arise (for example with the new in 3.13 ThreadingMock). The majority of our mocking needs are relatively simple, and have been fulfilled by even the earliest versions of mock, long before it became part of the stdlib. This removes a dependency from webkitcorepy, which feels like an especially big win.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/38097
Radar WebKit Bug Importer
<rdar://problem/142003431>
EWS
Committed 292652@main (331b82635e5a): <https://commits.webkit.org/292652@main>
Reviewed commits have been landed. Closing PR #38097 and removing active labels.