Bug 284726
| Summary: | WPT regression for css/css-tables/html-to-css-mapping-2.html | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | dholbert, koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://wpt.live/css/css-tables/html-to-css-mapping-2.html | ||
| Bug Depends on: | 195016 | ||
| Bug Blocks: | |||
Karl Dubost
When fixing Bug 195016
table border-color should be currentColor by default, not gray
with
https://github.com/WebKit/WebKit/pull/33916
The test
https://github.com/web-platform-tests/wpt/blob/38623a53d6598cb7aab4be8a810102b352a652df/css/css-tables/html-to-css-mapping-2.html
progressed one test, but regressed 5 others.
```
git diff a1fc5cb7c15cd65d8c5b784f8f0e6db3fb2df7df..main -- ../../LayoutTests/imported/w3c/web-platform-tests/css/css-tables/html-to-css-mapping-2-expected.txt
```
Gives:
```diff
diff --git a/LayoutTests/imported/w3c/web-platform-tests/css/css-tables/html-to-css-mapping-2-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/css/css-tables/html-to-css-mapping-2-expected.txt
index 65dcc14e8ce3..444f05f14f3c 100644
--- a/LayoutTests/imported/w3c/web-platform-tests/css/css-tables/html-to-css-mapping-2-expected.txt
+++ b/LayoutTests/imported/w3c/web-platform-tests/css/css-tables/html-to-css-mapping-2-expected.txt
@@ -53,13 +53,13 @@ border-color:gray comes from table[border=$w]
PASS 1: HTML -> CSS Mapping for borders is applied correctly on table markup (table left width)
PASS 1: HTML -> CSS Mapping for borders is applied correctly on table markup (table left style)
-PASS 1: HTML -> CSS Mapping for borders is applied correctly on table markup (table left color)
+FAIL 1: HTML -> CSS Mapping for borders is applied correctly on table markup (table left color) assert_equals: expected "rgb(128, 128, 128)" but got "rgb(0, 0, 0)"
PASS 2: HTML -> CSS Mapping for borders is applied correctly on table markup (table left width)
FAIL 2: HTML -> CSS Mapping for borders is applied correctly on table markup (table left style) assert_equals: expected "outset" but got "solid"
-FAIL 2: HTML -> CSS Mapping for borders is applied correctly on table markup (table left color) assert_equals: expected "rgb(0, 0, 0)" but got "rgb(128, 128, 128)"
+PASS 2: HTML -> CSS Mapping for borders is applied correctly on table markup (table left color)
FAIL 3a: HTML -> CSS Mapping for borders is applied correctly on table markup (table left width) assert_equals: expected "10px" but got "1px"
FAIL 3a: HTML -> CSS Mapping for borders is applied correctly on table markup (table left style) assert_equals: expected "outset" but got "solid"
-PASS 3a: HTML -> CSS Mapping for borders is applied correctly on table markup (table left color)
+FAIL 3a: HTML -> CSS Mapping for borders is applied correctly on table markup (table left color) assert_equals: expected "rgb(128, 128, 128)" but got "rgb(0, 0, 0)"
FAIL 3b: HTML -> CSS Mapping for borders is applied correctly on table markup (td top width) assert_equals: expected "1px" but got "0px"
FAIL 3b: HTML -> CSS Mapping for borders is applied correctly on table markup (td top style) assert_equals: expected "inset" but got "none"
FAIL 3b: HTML -> CSS Mapping for borders is applied correctly on table markup (td top color) assert_equals: expected "rgb(128, 128, 128)" but got "rgb(0, 0, 0)"
@@ -68,12 +68,12 @@ FAIL 3c: HTML -> CSS Mapping for borders is applied correctly on table markup (t
FAIL 3c: HTML -> CSS Mapping for borders is applied correctly on table markup (td left color) assert_equals: expected "rgb(128, 128, 128)" but got "rgb(0, 0, 0)"
PASS 4: HTML -> CSS Mapping for borders is applied correctly on table markup (table left width)
PASS 4: HTML -> CSS Mapping for borders is applied correctly on table markup (table left style)
-PASS 4: HTML -> CSS Mapping for borders is applied correctly on table markup (table left color)
+FAIL 4: HTML -> CSS Mapping for borders is applied correctly on table markup (table left color) assert_equals: expected "rgb(128, 128, 128)" but got "rgb(0, 0, 0)"
PASS 4: HTML -> CSS Mapping for borders is applied correctly on table markup (td left width)
PASS 4: HTML -> CSS Mapping for borders is applied correctly on table markup (td left style)
-PASS 4: HTML -> CSS Mapping for borders is applied correctly on table markup (td left color)
+FAIL 4: HTML -> CSS Mapping for borders is applied correctly on table markup (td left color) assert_equals: expected "rgb(128, 128, 128)" but got "rgb(0, 0, 0)"
PASS 5a: HTML -> CSS Mapping for borders is applied correctly on table markup (table left style)
FAIL 5b: HTML -> CSS Mapping for borders is applied correctly on table markup (table right width) assert_equals: expected "10px" but got "1px"
PASS 5b: HTML -> CSS Mapping for borders is applied correctly on table markup (table right style)
-PASS 5b: HTML -> CSS Mapping for borders is applied correctly on table markup (table right color)
+FAIL 5b: HTML -> CSS Mapping for borders is applied correctly on table markup (table right color) assert_equals: expected "rgb(128, 128, 128)" but got "rgb(0, 0, 0)"
```
There is probably some other differences to fix with regards to the way the table colors are applied.
see http://wpt.live/css/css-tables/html-to-css-mapping-2.html for the live test.
Regressed.
1. Table left color (failed by Firefox too)
3a. Table left color (failed by Firefox too)
4. Table left color. (failed by Firefox too)
5b. Tablet left color (failed by Firefox too)
Mozilla Bugzilla
https://bugzilla.mozilla.org/show_bug.cgi?id=1887417
Is it an issue with the tests?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Karl Dubost
I also filed https://github.com/w3c/csswg-drafts/issues/11377
and note the same test regression for Firefox.
https://bugzilla.mozilla.org/show_bug.cgi?id=1887417
Radar WebKit Bug Importer
<rdar://problem/141526764>
Karl Dubost
I have the feeling the test needs to be updated.
Some of these tests are also failed by all browsers.