Bug 28470

Summary:

Cookies, Session Storage and Local Storage need new icons

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Screenshot	none
Proposed Patch	none
Proposed Patch	none

Timothy Hatcher

Reported 2009-08-19 12:54:25 PDT

The Cookies, Session Storage and Local Storage need new icons.

Attachments
Screenshot (28.78 KB, image/png) 2009-08-19 13:39 PDT, Timothy Hatcher	no flags	Details
Proposed Patch (2.33 KB, patch) 2009-08-19 13:42 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Proposed Patch (3.99 KB, patch) 2009-08-19 13:43 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2009-08-19 13:39:00 PDT

Created attachment 35137 [details] Screenshot

Timothy Hatcher

Comment 2 2009-08-19 13:42:58 PDT

Created attachment 35138 [details] Proposed Patch Reviewed by Eric Seidel Add 'icu::' qualifier when refering to ICU C++ names. https://bugs.webkit.org/show_bug.cgi?id=28410 No change in the test result. * platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47506 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- 2 files changed, 16 insertions(+), 3 deletions(-)

Timothy Hatcher

Comment 3 2009-08-19 13:43:42 PDT

Comment on attachment 35138 [details] Proposed Patch bugzilla-tool fail.

Timothy Hatcher

Comment 4 2009-08-19 13:43:59 PDT

Created attachment 35139 [details] Proposed Patch Session Storage and Cookies. https://bugs.webkit.org/show_bug.cgi?id=28470 Reviewed by NOBODY (OOPS!). * inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.addDOMStorage): (WebInspector.DOMStorageSidebarTreeElement): * inspector/front-end/Images/cookie.png: * inspector/front-end/Images/domStorage.png: Removed. * inspector/front-end/Images/localStorage.png: Added. * inspector/front-end/Images/sessionStorage.png: Added. * inspector/front-end/inspector.css: --- 7 files changed, 27 insertions(+), 5 deletions(-)

Timothy Hatcher

Comment 5 2009-08-21 11:33:54 PDT

Landed in r47580.

Eric Seidel (no email)

Comment 6 2009-08-21 12:04:26 PDT

Comment on attachment 35139 [details] Proposed Patch I believe this was landed.

Note You need to log in before you can comment on or make changes to this bug.