Bug 284663
| Summary: | [Navigation API] NavigationHistoryEntry JS wrapper is not kept alive until the dispose event is fired | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Page Loading | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | beidson, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Dumez
When a NavigationHistoryEntry object gets removed from a Navigation object, a `dispose` event is dispatched on the NavigationHistoryEntry. However, NavigationHistoryEntry was not an ActiveDOMObject and therefore nothing was keeping its JS wrapper alive alive as long as a `dispose` event could get dispatched. This would lead to flaky crashes in the tests, when dispatching the event.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/37945
EWS
Committed 287839@main (4016aa647924): <https://commits.webkit.org/287839@main>
Reviewed commits have been landed. Closing PR #37945 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/141490633>