Bug 284592
| Summary: | Implement dialog closedby attribute | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mason Freed <masonf> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | afrehner.work, annevk, ik, karlcow, lwarlow, ntim, ryan, webkit-bug-importer, webkit.org |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=285989 | ||
| Bug Depends on: | 274717, 297954, 298200, 298201 | ||
| Bug Blocks: | |||
Mason Freed
This is an implementation bug for the new light dismiss behaviors (including closedby attribute and dialog.requestclose()) proposed here:
https://github.com/whatwg/html/pull/10737
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/141789116>
Luke Warlow
Moved dialog.requestClose() to its own bug as I believe it can be implemented separate to the other changes (which rely on CloseWatcher being implemented in WebKit). https://bugs.webkit.org/show_bug.cgi?id=285989
Luke Warlow
Assigning to myself, I have a prototype of the closedby="any" behaviour, am waiting on Close Watcher's to be merged and integrated with dialog so I can implement the closerequest and none values too.
Karl Dubost
Luke,
Since dialog.requestClose() has been merged, Would publishing the closedby="any" prototype be possible?
Luke Warlow
For the full closedby it needs wider close watcher support (I believe anyway, there may be a way to approximate it without that) but yes I think the best course of action is to get the prototype for closedby=any into a PR just have it behind a flag and then as more gets done we can finish it off.
Luke Warlow
https://github.com/whatwg/html/pull/11326 - for those tracking there was also some spec issues with the initial version of closedby which delayed things a bit while we resolved them. This is the final change neccessary before we have a solid base to work from.