Bug 284487

Summary: RenderText.isHorizontalWritingMode() returns incorrect value
Product: WebKit Reporter: fantasai <fantasai.bugs>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ahmad.saleem792, bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
testcase with underlining and shadows none

fantasai
Reported 2024-12-11 14:11:45 PST
Created attachment 473544 [details] testcase with underlining and shadows It seems like RenderText's StateFlag::VerticalWritingMode is not being set correctly, since we're painting text-decoration shadows using the horizontal mode offsets in TextDecorationPainter::paintBackgroundDecorations instead of the vertical ones. m_isHorizontal, which is set from TextBoxPainter's m_renderer.isHorizontalWritingMode() is true, while the WritingMode taken from RenderStyle is vertical. A workaround for the attached testcase is to use the WritingMode directly, but the fact that StateFlag::VerticalWritingMode is set incorrectly means there's probably additional problems in other parts of the code.
Attachments
testcase with underlining and shadows (794 bytes, text/html)
2024-12-11 14:11 PST, fantasai 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-12-18 14:12:14 PST
<rdar://problem/141708053>
fantasai
Comment 2 2025-01-08 14:00:43 PST
Implemented using WritingMode directly in bug 38426, so this particular testcase passes. But idk if the underlying bug is fixed.
alan
Comment 3 2025-01-08 16:54:21 PST
I fixed it in bug 284598.
alan
Comment 4 2025-01-08 16:54:36 PST
*** This bug has been marked as a duplicate of bug 284598 ***
Note You need to log in before you can comment on or make changes to this bug.