Bug 28443

Summary: Build break with gtk 2.10
Product: WebKit Reporter: Fumitoshi Ukai <ukai>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
fix build break with gtk_widget_get_window none

Fumitoshi Ukai
Reported 2009-08-18 20:50:53 PDT
WebKit requires gtk 2.10, but WebKit/gtk/WebCoreSupport/DragClientGtk.cpp requires gtk_widget_get_window that is introduced in gtk 2.14. ../WebKit/gtk/WebCoreSupport/DragClientGtk.cpp: In member function ‘virtual void WebKit::DragClient::startDrag(GdkPixbuf*, const WebCore::IntPoint&, const WebCore::IntPoint&, WebCore::Clipboard*, WebCore::Frame*, bool)’: ../WebKit/gtk/WebCoreSupport/DragClientGtk.cpp:92: error: ‘gtk_widget_get_window’ was not declared in this scope make[1]: *** [WebKit/gtk/WebCoreSupport/libwebkit_1_0_la-DragClientGtk.lo] Error 1
Attachments
fix build break with gtk_widget_get_window (1.23 KB, patch)
2009-08-18 21:00 PDT, Fumitoshi Ukai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fumitoshi Ukai
Comment 1 2009-08-18 21:00:10 PDT
Created attachment 35100 [details] fix build break with gtk_widget_get_window --- 2 files changed, 17 insertions(+), 1 deletions(-)
Eric Seidel (no email)
Comment 2 2009-08-18 23:35:10 PDT
Comment on attachment 35100 [details] fix build break with gtk_widget_get_window Looks sane enough.
Eric Seidel (no email)
Comment 3 2009-08-18 23:49:52 PDT
Comment on attachment 35100 [details] fix build break with gtk_widget_get_window Clearing flags on attachment: 35100 Committed r47496: <http://trac.webkit.org/changeset/47496>
Eric Seidel (no email)
Comment 4 2009-08-18 23:49:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.