Bug 284351
| Summary: | RepaintRects need to be recomputed when state changes that affects them | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 267252 | ||
Simon Fraser (smfr)
With the PR in bug 267252 applied, these two tests hit assertions in repaint rect verification (RenderLayer.cpp:1230):
imported/blink/fast/hidpi/border-background-align.html
printing/iframe-print.html
This is because bug 267252 eliminates a layout that happens when the state of `isPrinting` or deviceScaleFactor changes, so `updateLayerPositions()` doesn't do a full traversal, and we don't recompute new repaint rects.
printing/iframe-print.html asserts because the return value of `RenderView::computeVisibleRectsInContainer()` is affecting by printing.
imported/blink/fast/hidpi/border-background-align.html asserts because `deviceScaleFactor` affects rect rounding.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/141198097>
Simon Fraser (smfr)
Pull request: https://github.com/WebKit/WebKit/pull/37688
EWS
Committed 287607@main (abd0e960c37b): <https://commits.webkit.org/287607@main>
Reviewed commits have been landed. Closing PR #37688 and removing active labels.