Bug 284350

Summary:	Revert 287558@main 287570@main for causing linkage failures
Product:	WebKit	Reporter:	Simon Fraser (smfr) <simon.fraser>
Component:	Website Storage	Assignee:	Simon Fraser (smfr) <simon.fraser>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	andresg_22, jbedard, sihui_liu, simon.fraser, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Simon Fraser (smfr)

Reported 2024-12-09 20:35:41 PST

After 287558@main (with the build fix in 287570@main), WebKit failed to link with this failure: WebKit Ld WebKit Undefined symbols for architecture arm64e: "std::__1::optional<JSC::JSValue> IPC::jsValueForDecodedMessage<(IPC::MessageName)2563>(JSC::JSGlobalObject*, IPC::Decoder&)", referenced from: IPC::jsValueForArguments(JSC::JSGlobalObject*, IPC::MessageName, IPC::Decoder&) in MessageArgumentDescriptions.o "std::__1::optional<JSC::JSValue> IPC::jsValueForDecodedMessage<(IPC::MessageName)3793>(JSC::JSGlobalObject*, IPC::Decoder&)", referenced from: IPC::jsValueForArguments(JSC::JSGlobalObject*, IPC::MessageName, IPC::Decoder&) in MessageArgumentDescriptions.o "std::__1::optional<JSC::JSValue> IPC::jsValueForDecodedMessageReply<(IPC::MessageName)2559>(JSC::JSGlobalObject*, IPC::Decoder&)", referenced from: IPC::jsValueForReplyArguments(JSC::JSGlobalObject*, IPC::MessageName, IPC::Decoder&) in MessageArgumentDescriptions.o "std::__1::optional<JSC::JSValue> IPC::jsValueForDecodedMessageReply<(IPC::MessageName)2563>(JSC::JSGlobalObject*, IPC::Decoder&)", referenced from: IPC::jsValueForReplyArguments(JSC::JSGlobalObject*, IPC::MessageName, IPC::Decoder&) in MessageArgumentDescriptions.o "std::__1::optional<JSC::JSValue> IPC::jsValueForDecodedMessageReply<(IPC::MessageName)3793>(JSC::JSGlobalObject*, IPC::Decoder&)", referenced from: IPC::jsValueForReplyArguments(JSC::JSGlobalObject*, IPC::MessageName, IPC::Decoder&) in MessageArgumentDescriptions.o when building with certain SDKs. The #undef HAVE_ALLOW_ONLY_PARTITIONED_COOKIES in CFNetworkSPI.h causes the value of HAVE(ALLOW_ONLY_PARTITIONED_COOKIES) to be different in different files.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-12-09 20:35:53 PST

<rdar://problem/141197171>

Simon Fraser (smfr)

Comment 2 2024-12-09 20:45:36 PST

Pull request: https://github.com/WebKit/WebKit/pull/37687

EWS

Comment 3 2024-12-09 20:47:57 PST

Committed 287585@main (f23a1541d7eb): <https://commits.webkit.org/287585@main> Reviewed commits have been landed. Closing PR #37687 and removing active labels.

Jonathan Bedard

Comment 4 2024-12-10 08:10:34 PST

*** Bug 284353 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.