Bug 284312 – `git-webkit pr` raises when on detached HEAD

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Sam Sneddon [:gsnedders]]

gsnedders@gsnedders-margot WebKit % ./Tools/Scripts/git-webkit pr --commit
Traceback (most recent call last):
  File "/Volumes/gsnedders/projects/WebKit/./Tools/Scripts/git-webkit", line 63, in <module>
    sys.exit(program.main(
  File "/Volumes/gsnedders/projects/WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 185, in main
    return parsed.main(
  File "/Volumes/gsnedders/projects/WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py", line 754, in main
    branch_point = cls.pull_request_branch_point(repository, args, **kwargs)
  File "/Volumes/gsnedders/projects/WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py", line 254, in pull_request_branch_point
    if not repository.dev_branches.match(repository.branch) and (repository.branch is None or repository.branch in repository.DEFAULT_BRANCHES or
TypeError: expected string or bytes-like object

This is a regression from https://commits.webkit.org/287226@main, bug 283444.

This is from the newly added `not repository.dev_branches.match(repository.branch)`, because this is always evaluated, even when `repository.branch` is `None`, and `re.Pattern.match` cannot match against `None`.

[Radar WebKit Bug Importer]

<rdar://problem/141172754>

[Brianna Fan]

Pull request: https://github.com/WebKit/WebKit/pull/37655

[EWS]

Committed 288027@main (58deabc6ad47): <https://commits.webkit.org/288027@main>

Reviewed commits have been landed. Closing PR #37655 and removing active labels.