Bug 284256

Summary:	Avoid refcount churn for FillLayers without images
Product:	WebKit	Reporter:	Matt Woodrow <mattwoodrow>
Component:	Layout and Rendering	Assignee:	Matt Woodrow <mattwoodrow>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Matt Woodrow

Reported 2024-12-08 17:34:14 PST

The background layers and mask layers property on RenderStyle always has at least one FillLayer, even without an image. updateFillImages increments and then decrements the refcount of these for every element with a changed style in RenderElement::styleDidChange.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-12-08 17:34:23 PST

<rdar://problem/141130071>

Matt Woodrow

Comment 2 2024-12-08 17:36:56 PST

Pull request: https://github.com/WebKit/WebKit/pull/37609

EWS

Comment 3 2024-12-09 16:56:32 PST

Committed 287581@main (9eca15d5df1c): <https://commits.webkit.org/287581@main> Reviewed commits have been landed. Closing PR #37609 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.