Bug 28415

Summary:

Set svn:eol-style CRLF on *.sln, *.vcproj

Product:

WebKit

Reporter:

Peter Kasting <pkasting>

Component:

WebCore Misc.

Assignee:

Peter Kasting <pkasting>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
patch	eric: review+, eric: commit-queue-

Peter Kasting

Reported 2009-08-17 17:45:00 PDT

Created attachment 35003 [details] patch Most of the .sln and .vcproj files in the tree already have svn:eol-style set to CRLF, but a few don't. This makes life harder on people creating patches to these files (line endings can get out of sync). Patch attached. Note that prepare-ChangeLog does not detect svn-property-only changes, and so did not create any ChangeLog entries for this. I can add some manually if required.

Attachments
patch (1.78 KB, patch) 2009-08-17 17:45 PDT, Peter Kasting	eric: review+ eric: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2009-08-17 17:48:26 PDT

Comment on attachment 35003 [details] patch Yes, please add a manual ChangeLog. Seems we need a pre-commit hook for this eventually. Or some sort of script to validate these sorts of rules for the whole repository.

Peter Kasting

Comment 2 2009-08-18 10:44:29 PDT

Fixed in r47430.

Note You need to log in before you can comment on or make changes to this bug.