Bug 28415

Summary: Set svn:eol-style CRLF on *.sln, *.vcproj
Product: WebKit Reporter: Peter Kasting <pkasting>
Component: WebCore Misc.Assignee: Peter Kasting <pkasting>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch eric: review+, eric: commit-queue-

Description Peter Kasting 2009-08-17 17:45:00 PDT
Created attachment 35003 [details]
patch

Most of the .sln and .vcproj files in the tree already have svn:eol-style set to CRLF, but a few don't.  This makes life harder on people creating patches to these files (line endings can get out of sync).

Patch attached.  Note that prepare-ChangeLog does not detect svn-property-only changes, and so did not create any ChangeLog entries for this.  I can add some manually if required.
Comment 1 Eric Seidel (no email) 2009-08-17 17:48:26 PDT
Comment on attachment 35003 [details]
patch

Yes, please add a manual ChangeLog.

Seems we need a pre-commit hook for this eventually.  Or some sort of script to validate these sorts of rules for the whole repository.
Comment 2 Peter Kasting 2009-08-18 10:44:29 PDT
Fixed in r47430.